Bug 171722 - [GStreamer] Do not report more errors after the first one
Summary: [GStreamer] Do not report more errors after the first one
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-05-05 04:05 PDT by Carlos Garcia Campos
Modified: 2017-05-05 05:05 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.32 KB, patch)
2017-05-05 04:07 PDT, Carlos Garcia Campos
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-05-05 04:05:34 PDT
We can receive several error messages for the same error from different elements. That's confusing the media source selection algorithm implementation. I don't know if didn't happen with previous versions of GST, but since the upgrade to 1.10.4 several tests are failing because of this.
Comment 1 Carlos Garcia Campos 2017-05-05 04:07:32 PDT
Created attachment 309158 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2017-05-05 04:57:04 PDT
Comment on attachment 309158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309158&action=review

> Source/WebCore/ChangeLog:8
> +        We can receive several error messages for the same error from different elements. That's confusing the media

... That's confusing FOR the media source ...
Comment 3 Carlos Garcia Campos 2017-05-05 05:00:21 PDT
(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 309158 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309158&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        We can receive several error messages for the same error from different elements. That's confusing the media
> 
> ... That's confusing FOR the media source ...

I meant the media source alg impl gets confused by this. Not sure it's correct English, though.
Comment 4 Carlos Garcia Campos 2017-05-05 05:05:49 PDT
Committed r216240: <http://trac.webkit.org/changeset/216240>