WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
171588
Make the [EnabledBySetting] extended attribute work for any attribute or operation on a prototype
https://bugs.webkit.org/show_bug.cgi?id=171588
Summary
Make the [EnabledBySetting] extended attribute work for any attribute or oper...
Sam Weinig
Reported
2017-05-02 18:11:17 PDT
Make the [EnabledBySetting] extended attribute work for any attribute or operation on a prototype
Attachments
Patch
(136.22 KB, patch)
2017-05-02 18:23 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2017-05-02 18:23:41 PDT
Created
attachment 308876
[details]
Patch
Dean Jackson
Comment 2
2017-05-04 10:55:04 PDT
Comment on
attachment 308876
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=308876&action=review
> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2891 > +} > + > +#endif
Nit: the #if had no blank line before the code.
> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4564 > + > +#endif
ditto
WebKit Commit Bot
Comment 3
2017-05-04 11:39:07 PDT
Comment on
attachment 308876
[details]
Patch Clearing flags on attachment: 308876 Committed
r216198
: <
http://trac.webkit.org/changeset/216198
>
WebKit Commit Bot
Comment 4
2017-05-04 11:39:09 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug