Bug 171588 - Make the [EnabledBySetting] extended attribute work for any attribute or operation on a prototype
Summary: Make the [EnabledBySetting] extended attribute work for any attribute or oper...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks: 148363
  Show dependency tree / graph
 
Reported: 2017-05-02 18:11 PDT by Sam Weinig
Modified: 2017-05-04 11:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (136.22 KB, patch)
2017-05-02 18:23 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-05-02 18:11:17 PDT 
Make the [EnabledBySetting] extended attribute work for any attribute or operation on a prototype
Comment 1 Sam Weinig 2017-05-02 18:23:41 PDT 
Created attachment 308876 [details]
Patch
Comment 2 Dean Jackson 2017-05-04 10:55:04 PDT 
Comment on attachment 308876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308876&action=review

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2891
> +}
> +
> +#endif

Nit: the #if had no blank line before the code.

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4564
> +
> +#endif

ditto
Comment 3 WebKit Commit Bot 2017-05-04 11:39:07 PDT 
Comment on attachment 308876 [details]
Patch

Clearing flags on attachment: 308876

Committed r216198: <http://trac.webkit.org/changeset/216198>
Comment 4 WebKit Commit Bot 2017-05-04 11:39:09 PDT 
All reviewed patches have been landed.  Closing bug.