WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
171545
[Soup] Add request headers to network load metrics
https://bugs.webkit.org/show_bug.cgi?id=171545
Summary
[Soup] Add request headers to network load metrics
Carlos Garcia Campos
Reported
2017-05-02 03:39:37 PDT
This will make the headers to appear in the web inspector. It fixes http/tests/inspector/network/resource-request-headers.html
Attachments
Patch
(2.13 KB, patch)
2017-05-02 03:41 PDT
,
Carlos Garcia Campos
svillar
: review+
Details
Formatted Diff
Diff
Gardening patch for EWS
(3.90 KB, patch)
2017-05-03 23:48 PDT
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
Gardening patch for EWS
(3.90 KB, patch)
2017-05-04 00:00 PDT
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2017-05-02 03:41:10 PDT
Created
attachment 308815
[details]
Patch
Joseph Pecoraro
Comment 2
2017-05-02 11:39:09 PDT
Comment on
attachment 308815
[details]
Patch Nice!
Carlos Garcia Campos
Comment 3
2017-05-03 00:15:53 PDT
Committed
r216111
: <
http://trac.webkit.org/changeset/216111
>
Carlos Garcia Campos
Comment 4
2017-05-03 02:20:07 PDT
Test http/tests/inspector/network/resource-request-headers.html is still failing in the bots, but because the expected fail expects to fails PASS: Response should have a 'WWW-Authenticate' response header for the failure. -FAIL: 'Authorization' header value should be for badUsername:badPassword. - Expected: "Basic YmFkVXNlcm5hbWU6YmFkUGFzc3dvcmQ=" - Actual: undefined +PASS: 'Authorization' header value should be for badUsername:badPassword. -- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.Success PASS: Resource should be created Is that intentional Joe?
Joseph Pecoraro
Comment 5
2017-05-03 12:27:56 PDT
(In reply to Carlos Garcia Campos from
comment #4
)
> Test http/tests/inspector/network/resource-request-headers.html is still > failing in the bots, but because the expected fail expects to fails > > PASS: Response should have a 'WWW-Authenticate' response header for the > failure. > -FAIL: 'Authorization' header value should be for badUsername:badPassword. > - Expected: "Basic YmFkVXNlcm5hbWU6YmFkUGFzc3dvcmQ=" > - Actual: undefined > +PASS: 'Authorization' header value should be for badUsername:badPassword. > > -- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.Success > PASS: Resource should be created > > Is that intentional Joe?
I've seen this occasionally on mac as well. This may be something with the test / testing code not correctly setting the user/pass for basic authentication. It uses testRunner APIs and maybe it isn't being used correctly.
Joseph Pecoraro
Comment 6
2017-05-03 16:25:00 PDT
(In reply to Joseph Pecoraro from
comment #5
)
> (In reply to Carlos Garcia Campos from
comment #4
) > > Test http/tests/inspector/network/resource-request-headers.html is still > > failing in the bots, but because the expected fail expects to fails > > I've seen this occasionally on mac as well. This may be something with the > test / testing code not correctly setting the user/pass for basic > authentication. It uses testRunner APIs and maybe it isn't being used > correctly.
This is tracked by
bug 170702
.
Joseph Pecoraro
Comment 7
2017-05-03 16:28:29 PDT
Actually your case is badPassword. That might be a better expectation then cocoa ports. You may want to include your results as mainline and mac results as platform specific expectations? What do you think.
Carlos Garcia Campos
Comment 8
2017-05-03 23:12:45 PDT
(In reply to Joseph Pecoraro from
comment #7
)
> Actually your case is badPassword. That might be a better expectation then > cocoa ports. You may want to include your results as mainline and mac > results as platform specific expectations? What do you think.
Yes, it makes sense.
Carlos Garcia Campos
Comment 9
2017-05-03 23:48:04 PDT
Created
attachment 309021
[details]
Gardening patch for EWS
Carlos Garcia Campos
Comment 10
2017-05-04 00:00:32 PDT
Need to reopen for EWS to work
Carlos Garcia Campos
Comment 11
2017-05-04 00:00:53 PDT
Created
attachment 309023
[details]
Gardening patch for EWS
Joseph Pecoraro
Comment 12
2017-05-04 13:53:54 PDT
Comment on
attachment 309023
[details]
Gardening patch for EWS View in context:
https://bugs.webkit.org/attachment.cgi?id=309023&action=review
> LayoutTests/ChangeLog:8 > + * platform/mac-wk2/http/tests/inspector/network/resource-request-headers-expected.txt: Copied from LayoutTests/http/tests/inspector/network/resource-request-headers-expected.txt.
Looks good to me! This could even be platform/mac but platform/mac-wk2 works as well here since it only works for WebKit2 (NetworkSession). Thanks for cleaning this up.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug