Bug 171545 - [Soup] Add request headers to network load metrics
Summary: [Soup] Add request headers to network load metrics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-05-02 03:39 PDT by Carlos Garcia Campos
Modified: 2017-05-04 13:53 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.13 KB, patch)
2017-05-02 03:41 PDT, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff
Gardening patch for EWS (3.90 KB, patch)
2017-05-03 23:48 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Gardening patch for EWS (3.90 KB, patch)
2017-05-04 00:00 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-05-02 03:39:37 PDT
This will make the headers to appear in the web inspector. It fixes http/tests/inspector/network/resource-request-headers.html
Comment 1 Carlos Garcia Campos 2017-05-02 03:41:10 PDT
Created attachment 308815 [details]
Patch
Comment 2 Joseph Pecoraro 2017-05-02 11:39:09 PDT
Comment on attachment 308815 [details]
Patch

Nice!
Comment 3 Carlos Garcia Campos 2017-05-03 00:15:53 PDT
Committed r216111: <http://trac.webkit.org/changeset/216111>
Comment 4 Carlos Garcia Campos 2017-05-03 02:20:07 PDT
Test http/tests/inspector/network/resource-request-headers.html is still failing in the bots, but because the expected fail expects to fails

 PASS: Response should have a 'WWW-Authenticate' response header for the failure.
-FAIL: 'Authorization' header value should be for badUsername:badPassword.
-    Expected: "Basic YmFkVXNlcm5hbWU6YmFkUGFzc3dvcmQ="
-    Actual: undefined
+PASS: 'Authorization' header value should be for badUsername:badPassword.
 
 -- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.Success
 PASS: Resource should be created

Is that intentional Joe?
Comment 5 Joseph Pecoraro 2017-05-03 12:27:56 PDT
(In reply to Carlos Garcia Campos from comment #4)
> Test http/tests/inspector/network/resource-request-headers.html is still
> failing in the bots, but because the expected fail expects to fails
> 
>  PASS: Response should have a 'WWW-Authenticate' response header for the
> failure.
> -FAIL: 'Authorization' header value should be for badUsername:badPassword.
> -    Expected: "Basic YmFkVXNlcm5hbWU6YmFkUGFzc3dvcmQ="
> -    Actual: undefined
> +PASS: 'Authorization' header value should be for badUsername:badPassword.
>  
>  -- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.Success
>  PASS: Resource should be created
> 
> Is that intentional Joe?

I've seen this occasionally on mac as well. This may be something with the test / testing code not correctly setting the user/pass for basic authentication. It uses testRunner APIs and maybe it isn't being used correctly.
Comment 6 Joseph Pecoraro 2017-05-03 16:25:00 PDT
(In reply to Joseph Pecoraro from comment #5)
> (In reply to Carlos Garcia Campos from comment #4)
> > Test http/tests/inspector/network/resource-request-headers.html is still
> > failing in the bots, but because the expected fail expects to fails
> 
> I've seen this occasionally on mac as well. This may be something with the
> test / testing code not correctly setting the user/pass for basic
> authentication. It uses testRunner APIs and maybe it isn't being used
> correctly.

This is tracked by bug 170702.
Comment 7 Joseph Pecoraro 2017-05-03 16:28:29 PDT
Actually your case is badPassword. That might be a better expectation then cocoa ports. You may want to include your results as mainline and mac results as platform specific expectations? What do you think.
Comment 8 Carlos Garcia Campos 2017-05-03 23:12:45 PDT
(In reply to Joseph Pecoraro from comment #7)
> Actually your case is badPassword. That might be a better expectation then
> cocoa ports. You may want to include your results as mainline and mac
> results as platform specific expectations? What do you think.

Yes, it makes sense.
Comment 9 Carlos Garcia Campos 2017-05-03 23:48:04 PDT
Created attachment 309021 [details]
Gardening patch for EWS
Comment 10 Carlos Garcia Campos 2017-05-04 00:00:32 PDT
Need to reopen for EWS to work
Comment 11 Carlos Garcia Campos 2017-05-04 00:00:53 PDT
Created attachment 309023 [details]
Gardening patch for EWS
Comment 12 Joseph Pecoraro 2017-05-04 13:53:54 PDT
Comment on attachment 309023 [details]
Gardening patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=309023&action=review

> LayoutTests/ChangeLog:8
> +        * platform/mac-wk2/http/tests/inspector/network/resource-request-headers-expected.txt: Copied from LayoutTests/http/tests/inspector/network/resource-request-headers-expected.txt.

Looks good to me! This could even be platform/mac but platform/mac-wk2 works as well here since it only works for WebKit2 (NetworkSession).

Thanks for cleaning this up.