This will make the headers to appear in the web inspector. It fixes http/tests/inspector/network/resource-request-headers.html
Created attachment 308815 [details] Patch
Comment on attachment 308815 [details] Patch Nice!
Committed r216111: <http://trac.webkit.org/changeset/216111>
Test http/tests/inspector/network/resource-request-headers.html is still failing in the bots, but because the expected fail expects to fails PASS: Response should have a 'WWW-Authenticate' response header for the failure. -FAIL: 'Authorization' header value should be for badUsername:badPassword. - Expected: "Basic YmFkVXNlcm5hbWU6YmFkUGFzc3dvcmQ=" - Actual: undefined +PASS: 'Authorization' header value should be for badUsername:badPassword. -- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.Success PASS: Resource should be created Is that intentional Joe?
(In reply to Carlos Garcia Campos from comment #4) > Test http/tests/inspector/network/resource-request-headers.html is still > failing in the bots, but because the expected fail expects to fails > > PASS: Response should have a 'WWW-Authenticate' response header for the > failure. > -FAIL: 'Authorization' header value should be for badUsername:badPassword. > - Expected: "Basic YmFkVXNlcm5hbWU6YmFkUGFzc3dvcmQ=" > - Actual: undefined > +PASS: 'Authorization' header value should be for badUsername:badPassword. > > -- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.Success > PASS: Resource should be created > > Is that intentional Joe? I've seen this occasionally on mac as well. This may be something with the test / testing code not correctly setting the user/pass for basic authentication. It uses testRunner APIs and maybe it isn't being used correctly.
(In reply to Joseph Pecoraro from comment #5) > (In reply to Carlos Garcia Campos from comment #4) > > Test http/tests/inspector/network/resource-request-headers.html is still > > failing in the bots, but because the expected fail expects to fails > > I've seen this occasionally on mac as well. This may be something with the > test / testing code not correctly setting the user/pass for basic > authentication. It uses testRunner APIs and maybe it isn't being used > correctly. This is tracked by bug 170702.
Actually your case is badPassword. That might be a better expectation then cocoa ports. You may want to include your results as mainline and mac results as platform specific expectations? What do you think.
(In reply to Joseph Pecoraro from comment #7) > Actually your case is badPassword. That might be a better expectation then > cocoa ports. You may want to include your results as mainline and mac > results as platform specific expectations? What do you think. Yes, it makes sense.
Created attachment 309021 [details] Gardening patch for EWS
Need to reopen for EWS to work
Created attachment 309023 [details] Gardening patch for EWS
Comment on attachment 309023 [details] Gardening patch for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=309023&action=review > LayoutTests/ChangeLog:8 > + * platform/mac-wk2/http/tests/inspector/network/resource-request-headers-expected.txt: Copied from LayoutTests/http/tests/inspector/network/resource-request-headers-expected.txt. Looks good to me! This could even be platform/mac but platform/mac-wk2 works as well here since it only works for WebKit2 (NetworkSession). Thanks for cleaning this up.