[macOS Sierra] LayoutTest http/tests/inspector/network/resource-request-headers.html is a flaky failure

[Ryan Haddad]

LayoutTest http/tests/inspector/network/resource-request-headers.html is a flaky failure

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r215180%20(401)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fresource-request-headers.html

--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/inspector/network/resource-request-headers-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/inspector/network/resource-request-headers-actual.txt
@@ -34,5 +34,7 @@
 PASS: Resource should be created.
 PASS: Resource should receive a Response.
 PASS: Resource should have a 200 status code.
-PASS: 'Authorization' header value should be for goodUsername:goodPassword.
+FAIL: 'Authorization' header value should be for goodUsername:goodPassword.
+    Expected: "Basic Z29vZFVzZXJuYW1lOmdvb2RQYXNzd29yZA=="
+    Actual: undefined

[Ryan Haddad]

This test was added with https://trac.webkit.org/changeset/215062/webkit

[Joseph Pecoraro]

Arg this will need to be marked flakey until I have time to investigate.

[Ryan Haddad]

(In reply to Joseph Pecoraro from comment #2)
> Arg this will need to be marked flakey until I have time to investigate.

Done in https://trac.webkit.org/changeset/215338/webkit

[Radar WebKit Bug Importer]

<rdar://problem/31616643>

[Joseph Pecoraro]

Adding InspectorTest.debug() I see:
>    event: {"method":"Network.requestWillBeSent","params":{"requestId":"0.330","frameId":"0.1","loaderId":"0.91","documentURL":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","request":{"url":"http://goodUsername:goodPassword@127.0.0.1:8000/inspector/network/resources/basic-auth.php?0.33697814343205157","method":"GET","headers":{"Referer":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","Accept":"*/*","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/604.1.22+ (KHTML, like Gecko)"}},"timestamp":0.9208538240000053,"initiator":{"type":"script","stackTrace":[{"functionName":"send","url":"[native code]","scriptId":"0","lineNumber":0,"columnNumber":0},{"functionName":"triggerNetworkLoadWithBasicAuthentication","url":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","scriptId":"1934","lineNumber":18,"columnNumber":13},{"functionName":"triggerNetworkLoadWithBasicAuthenticationSuccess","url":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","scriptId":"1934","lineNumber":40,"columnNumber":46},{"functionName":"global code","url":"","scriptId":"1967","lineNumber":1,"columnNumber":49},{"functionName":"evaluateWithScopeExtension","url":"[native code]","scriptId":"0","lineNumber":0,"columnNumber":0},{"functionName":"_evaluateOn","url":"","scriptId":"1935","lineNumber":100,"columnNumber":29},{"functionName":"_evaluateAndWrap","url":"","scriptId":"1935","lineNumber":93,"columnNumber":105},{"functionName":"evaluate","url":"","scriptId":"1935","lineNumber":83,"columnNumber":30}]},"type":"XHR"}}
>    response: {"result":{"result":{"type":"undefined"},"wasThrown":false},"id":57}
>    event: {"method":"Network.responseReceived","params":{"requestId":"0.330","frameId":"0.1","loaderId":"0.91","timestamp":0.9282765010000276,"type":"XHR","response":{"url":"http://127.0.0.1:8000/inspector/network/resources/basic-auth.php?0.33697814343205157","status":200,"statusText":"OK","headers":{"Content-Type":"text/html","Date":"Thu, 04 May 2017 23:58:00 GMT","Connection":"Keep-Alive","Server":"Apache/2.4.25 (Unix) PHP/5.6.30 LibreSSL/2.2.7","Content-Length":"8","Keep-Alive":"timeout=15, max=100","X-Powered-By":"PHP/5.6.30"},"mimeType":"text/html","source":"network","timing":{"startTime":0.9201104710000436,"domainLookupStart":0.565946102142334,"domainLookupEnd":0.565946102142334,"connectStart":0.565946102142334,"connectEnd":0.565946102142334,"secureConnectionStart":-1000,"requestStart":0.7959604263305664,"responseStart":1.3339519500732422}}}}
>    event: {"method":"Network.dataReceived","params":{"requestId":"0.330","timestamp":0.9285717630000363,"dataLength":8,"encodedDataLength":8}}
>    FAIL: 'Authorization' header value should be for goodUsername:goodPassword.
>        Expected: "Basic Z29vZFVzZXJuYW1lOmdvb2RQYXNzd29yZA=="
>        Actual: undefined
>    request: {"id":61,"method":"Runtime.evaluate","params":{"expression":"TestPage.addResult(unescape(\"FAIL%3A%20%27Authorization%27%20header%20value%20should%20be%20for%20goodUsername%3AgoodPassword.%0A%20%20%20%20Expected%3A%20%22Basic%20Z29vZFVzZXJuYW1lOmdvb2RQYXNzd29yZA%3D%3D%22%0A%20%20%20%20Actual%3A%20undefined\"))","objectGroup":"test","includeCommandLineAPI":false}}
>    completeTest()
>    event: {"method":"Network.loadingFinished","params":{"requestId":"0.330","timestamp":0.9215144584077279,"metrics":{"protocol":"http/1.1","priority":"medium","requestHeaders":{"Referer":"http://127.0.0.1:8000/inspector/network/resource-request-headers.html","Host":"127.0.0.1:8000","Accept":"*/*","Connection":"keep-alive","Accept-Language":"en-us","Accept-Encoding":"gzip, deflate","Authorization":"Basic Z29vZFVzZXJuYW1lOmdvb2RQYXNzd29yZA==","Cookie":"InspectorTestCookie=1234","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/604.1.22+ (KHTML, like Gecko)"}}}}

So the test is checking the values before the Network load has finished (Network.loadingFinished).

I'll wait for the loading finished event.

[Joseph Pecoraro]

Created attachment 309115 [details]
[PATCH] Proposed Fix

[BJ Burg]

Comment on attachment 309115 [details]
[PATCH] Proposed Fix

rs=me

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/216266/webkit>