Bug 171512 - Stop using sprintf() in JavaScriptCore debugger
Summary: Stop using sprintf() in JavaScriptCore debugger
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on: 171494
  Show dependency treegraph
Reported: 2017-05-01 13:56 PDT by David Kilzer (:ddkilzer)
Modified: 2017-05-02 02:49 PDT (History)
9 users (show)

See Also:

Patch v1 (3.64 KB, patch)
2017-05-01 15:17 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-05-01 13:56:11 PDT
$ ./Tools/Scripts/check-webkit-style --filter="-,+security/" Source/JavaScriptCore
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86.c:175:  Never use sprintf.  Use snprintf instead.  [security/printf] [5]
Total errors found: 1 in 2781 files

Found via re-enabled checkers from Bug 171494.
Comment 1 David Kilzer (:ddkilzer) 2017-05-01 15:17:24 PDT
Created attachment 308774 [details]
Patch v1
Comment 2 Keith Miller 2017-05-01 17:31:21 PDT
Comment on attachment 308774 [details]
Patch v1

Comment 3 WebKit Commit Bot 2017-05-01 18:00:38 PDT
Comment on attachment 308774 [details]
Patch v1

Clearing flags on attachment: 308774

Committed r216049: <http://trac.webkit.org/changeset/216049>
Comment 4 WebKit Commit Bot 2017-05-01 18:00:40 PDT
All reviewed patches have been landed.  Closing bug.