Bug 171494 - check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
Summary: check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks: 171512 171517 171520
  Show dependency tree / graph
 
Reported: 2017-05-01 06:47 PDT by David Kilzer (:ddkilzer)
Modified: 2017-05-01 15:49 PDT (History)
11 users (show)

See Also:

Attachments
Patch v1 (5.37 KB, patch)
2017-05-01 06:54 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-05-01 06:47:38 PDT 
I'm guessing these checks were disabled because all of the "runtime/printf" checks together were too verbose when the original check-webkit-style was committed in 2009 in r45857.

However, this meant that functions like strcat() and strcpy() were allowed to be committed into the WebKit tree at various times (see Bug 170994).

We should turn these checks back on under a new category.
Comment 1 David Kilzer (:ddkilzer) 2017-05-01 06:54:43 PDT 
Created attachment 308719 [details]
Patch v1
Comment 2 Brent Fulgham 2017-05-01 09:36:29 PDT 
Comment on attachment 308719 [details]
Patch v1

r=me.
Comment 3 WebKit Commit Bot 2017-05-01 10:06:43 PDT 
Comment on attachment 308719 [details]
Patch v1

Clearing flags on attachment: 308719

Committed r216017: <http://trac.webkit.org/changeset/216017>
Comment 4 WebKit Commit Bot 2017-05-01 10:06:45 PDT 
All reviewed patches have been landed.  Closing bug.