Regression (r215941) Unexpected logging causes perf tests to fail
<rdar://problem/31907269>
<rdar://problem/31907270>
Created attachment 308684 [details] Patch
Comment on attachment 308684 [details] Patch Clearing flags on attachment: 308684 Committed r215983: <http://trac.webkit.org/changeset/215983>
All reviewed patches have been landed. Closing bug.
(In reply to WebKit Commit Bot from comment #4) > Comment on attachment 308684 [details] > Patch > > Clearing flags on attachment: 308684 > > Committed r215983: <http://trac.webkit.org/changeset/215983> It appears that perf tests are still failing after this change: 2017-05-01 13:53:04.797 WebKitTestRunner[24779:798669] could not create directory "" for future sandbox extension, error Error Domain=NSCocoaErrorDomain Code=512 "The file “” couldn’t be saved." UserInfo={NSFilePath=} https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Perf)/builds/319
(In reply to Ryan Haddad from comment #6) > (In reply to WebKit Commit Bot from comment #4) > > Comment on attachment 308684 [details] > > Patch > > > > Clearing flags on attachment: 308684 > > > > Committed r215983: <http://trac.webkit.org/changeset/215983> > > It appears that perf tests are still failing after this change: > > 2017-05-01 13:53:04.797 WebKitTestRunner[24779:798669] could not create > directory "" for future sandbox extension, error Error > Domain=NSCocoaErrorDomain Code=512 "The file “” couldn’t be saved." > UserInfo={NSFilePath=} > > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Release%20WK2%20(Perf)/builds/319 hmmmm based on code inspection that's quite surprising. Will have to run locally with more logging to explore.
(In reply to Brady Eidson from comment #7) > (In reply to Ryan Haddad from comment #6) > > (In reply to WebKit Commit Bot from comment #4) > > > Comment on attachment 308684 [details] > > > Patch > > > > > > Clearing flags on attachment: 308684 > > > > > > Committed r215983: <http://trac.webkit.org/changeset/215983> > > > > It appears that perf tests are still failing after this change: > > > > 2017-05-01 13:53:04.797 WebKitTestRunner[24779:798669] could not create > > directory "" for future sandbox extension, error Error > > Domain=NSCocoaErrorDomain Code=512 "The file “” couldn’t be saved." > > UserInfo={NSFilePath=} > > > > https://build.webkit.org/builders/ > > Apple%20El%20Capitan%20Release%20WK2%20(Perf)/builds/319 > > hmmmm based on code inspection that's quite surprising. > > Will have to run locally with more logging to explore. So far I've determined it's *not* my original cookie file change that's doing this. Huh
(In reply to Brady Eidson from comment #8) > (In reply to Brady Eidson from comment #7) > > (In reply to Ryan Haddad from comment #6) > > > (In reply to WebKit Commit Bot from comment #4) > > > > Comment on attachment 308684 [details] > > > > Patch > > > > > > > > Clearing flags on attachment: 308684 > > > > > > > > Committed r215983: <http://trac.webkit.org/changeset/215983> > > > > > > It appears that perf tests are still failing after this change: > > > > > > 2017-05-01 13:53:04.797 WebKitTestRunner[24779:798669] could not create > > > directory "" for future sandbox extension, error Error > > > Domain=NSCocoaErrorDomain Code=512 "The file “” couldn’t be saved." > > > UserInfo={NSFilePath=} > > > > > > https://build.webkit.org/builders/ > > > Apple%20El%20Capitan%20Release%20WK2%20(Perf)/builds/319 > > > > hmmmm based on code inspection that's quite surprising. > > > > Will have to run locally with more logging to explore. > > So far I've determined it's *not* my original cookie file change that's > doing this. Huh Fallout from my later IndexedDB change! Hah!
Following up in https://bugs.webkit.org/show_bug.cgi?id=171522