Bug 171522 – Only try to get sandbox extension handle for IndexedDB directory if it is set

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Only try to get sandbox extension handle for IndexedDB directory if it is set

[Radar WebKit Bug Importer]

<rdar://problem/31925828>

[Brady Eidson]

Created attachment 308784 [details]
Patch

[Andy Estes]

Comment on attachment 308784 [details]
Patch

Is this API-testable?

[Brady Eidson]

(In reply to Andy Estes from comment #3)
> Comment on attachment 308784 [details]
> Patch
> 
> Is this API-testable?

No, but testing infrastructure already caught this! (NSLogging causing perf tests to fail)

[WebKit Commit Bot]

Comment on attachment 308784 [details]
Patch

Clearing flags on attachment: 308784

Committed r216053: <http://trac.webkit.org/changeset/216053>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tim Horton]

Question! Why didn't you apply the same change to all the other directories? (AppCache/MediaCache/MediaKeys/WebSQL)?

[Brady Eidson]

(In reply to Tim Horton from comment #7)
> Question! Why didn't you apply the same change to all the other directories?
> (AppCache/MediaCache/MediaKeys/WebSQL)?

Because:
1 - it wasn't happening to them
2 - IndexedDB directory can optionally be null, but I'm sure at least some of those always get default directories

I'm guessing you're asking because one of my above answers is not true in some configuration.

Make that configuration fail in a test, then we'll have to fix the test :)