Bug 171522 - Only try to get sandbox extension handle for IndexedDB directory if it is set
Summary: Only try to get sandbox extension handle for IndexedDB directory if it is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-01 16:10 PDT by Brady Eidson
Modified: 2017-08-13 09:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.19 KB, patch)
2017-05-01 16:18 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-05-01 16:10:32 PDT
Only try to get sandbox extension handle for IndexedDB directory if it is set
Comment 1 Radar WebKit Bug Importer 2017-05-01 16:11:14 PDT
<rdar://problem/31925828>
Comment 2 Brady Eidson 2017-05-01 16:18:30 PDT
Created attachment 308784 [details]
Patch
Comment 3 Andy Estes 2017-05-01 16:20:57 PDT
Comment on attachment 308784 [details]
Patch

Is this API-testable?
Comment 4 Brady Eidson 2017-05-01 16:22:16 PDT
(In reply to Andy Estes from comment #3)
> Comment on attachment 308784 [details]
> Patch
> 
> Is this API-testable?

No, but testing infrastructure already caught this! (NSLogging causing perf tests to fail)
Comment 5 WebKit Commit Bot 2017-05-01 18:28:08 PDT
Comment on attachment 308784 [details]
Patch

Clearing flags on attachment: 308784

Committed r216053: <http://trac.webkit.org/changeset/216053>
Comment 6 WebKit Commit Bot 2017-05-01 18:28:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Tim Horton 2017-08-13 08:57:50 PDT
Question! Why didn't you apply the same change to all the other directories? (AppCache/MediaCache/MediaKeys/WebSQL)?
Comment 8 Brady Eidson 2017-08-13 09:19:08 PDT
(In reply to Tim Horton from comment #7)
> Question! Why didn't you apply the same change to all the other directories?
> (AppCache/MediaCache/MediaKeys/WebSQL)?

Because:
1 - it wasn't happening to them
2 - IndexedDB directory can optionally be null, but I'm sure at least some of those always get default directories

I'm guessing you're asking because one of my above answers is not true in some configuration.

Make that configuration fail in a test, then we'll have to fix the test :)