Bug 171346 - REGRESSION r215821: LayoutTest inspector/dom/getAccessibilityPropertiesForNode.html is failing
Summary: REGRESSION r215821: LayoutTest inspector/dom/getAccessibilityPropertiesForNod...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-26 15:33 PDT by Matt Lewis
Modified: 2017-04-26 16:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2017-04-26 15:50 PDT, Matt Lewis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-04-26 15:33:24 PDT 
REGRESSION r215821: LayoutTest inspector/dom/getAccessibilityPropertiesForNode.html is failing

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/808

diff:
--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-actual.txt
@@ -296,6 +296,7 @@
     focused: false
     ownedNodeIds.length: 1
     required: false
+    isPopUpButton: true
 
 <select>
     <option>FOO</option>
Comment 1 Ryan Haddad 2017-04-26 15:33:57 PDT 
It seems that this started after the change for https://bugs.webkit.org/show_bug.cgi?id=171164

I think we just need to rebaseline this test.
Comment 2 Matt Lewis 2017-04-26 15:50:39 PDT 
Created attachment 308295 [details]
Patch
Comment 3 Ryan Haddad 2017-04-26 16:33:09 PDT 
Comment on attachment 308295 [details]
Patch

Clearing flags on attachment: 308295

Committed r215839: <http://trac.webkit.org/changeset/215839>
Comment 4 Ryan Haddad 2017-04-26 16:33:10 PDT 
All reviewed patches have been landed.  Closing bug.