[ATK] Implement support for new ARIA 1.1 values of aria-haspopup

[Joanmarie Diggs]

For ATK, support for aria-haspopup requires:

1. Add STATE_HAS_POPUP to the state set
2. Expose the value of aria-haspopup via the "haspopup" object attribute

[Radar WebKit Bug Importer]

<rdar://problem/31774638>

[Radar WebKit Bug Importer]

<rdar://problem/31774659>

[Joanmarie Diggs]

Created attachment 308239 [details]
Patch

[Joanmarie Diggs]

Comment on attachment 308239 [details]
Patch

Chris: Please review when you have a chance. Thanks!

[chris fleizach]

Comment on attachment 308239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308239&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1013
> +    const AtomicString& haspopup = getAttribute(aria_haspopupAttr);

I think this can probably all move into AXObject.cpp and then this won't have to be virtual

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1014
> +    if (equalLettersIgnoringASCIICase(haspopup, "true")

should probably be hasPopup

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1032
> +    return String();

should this also return "false"?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1038
> +    return !haspopup.isEmpty() && !equalLettersIgnoringASCIICase(haspopup, "false");

if ariaPopupValue() returned false instead of empty string we wouldn't also need the isEmpty check here

[Joanmarie Diggs]

Created attachment 308269 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 308269 [details]
Patch

Clearing flags on attachment: 308269

Committed r215821: <http://trac.webkit.org/changeset/215821>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.