Bug 171204 – AX: Inconsistent exposure of ARIA "button" role with non-false value of aria-haspopup

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

A button where aria-pressed is undefined, and aria-haspopup is true, is exposed as:

  AXRole: AXPopUpButton
  AXSubrole: <nil>
  AXRoleDescription: 'pop up button'

But a button where aria-pressed is undefined, and aria-haspopup is one of the new values allowed in ARIA 1.1 [1] (e.g. aria-haspopup="dialog"), the 

  AXRole: AXButton
  AXSubrole: <nil>
  AXRoleDescription: 'button'

[1] https://rawgit.com/w3c/aria/master/aria/aria.html#aria-haspopup

[Radar WebKit Bug Importer]

<rdar://problem/31779284>

[Joanmarie Diggs]

Chris: If you think that ARIA buttons with a valid, non-false value of aria-haspopup should always be exposed on your platform as:

  AXRole: AXPopUpButton
  AXSubrole: <nil>
  AXRoleDescription: 'pop up button'

Then I have good news: I apparently fixed this bug as a side effect of the changes made for bug 171164.

It looks like we need a layout test for your platform since the above change wasn't caught. Before I do that, could you please confirm that I fixed something on your platform rather than broke it? If I broke it, then I'll of course accompany the new layout test with the restoration of the AXButton mapping.

Thanks!

[chris fleizach]

(In reply to Joanmarie Diggs (irc: joanie) from comment #2)
> Chris: If you think that ARIA buttons with a valid, non-false value of
> aria-haspopup should always be exposed on your platform as:
> 
>   AXRole: AXPopUpButton
>   AXSubrole: <nil>
>   AXRoleDescription: 'pop up button'
> 
> Then I have good news: I apparently fixed this bug as a side effect of the
> changes made for bug 171164.
> 
> It looks like we need a layout test for your platform since the above change
> wasn't caught. Before I do that, could you please confirm that I fixed
> something on your platform rather than broke it? If I broke it, then I'll of
> course accompany the new layout test with the restoration of the AXButton
> mapping.
> 
> Thanks!


I think that sounds correct. Presumably something still pops up  when the button is pressed, so we call it a popup button

[Joanmarie Diggs]

Created attachment 308390 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 308390 [details]
Patch

Clearing flags on attachment: 308390

Committed r215873: <http://trac.webkit.org/changeset/215873>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.