Bug 171183 - AX: Implement support for ARIA "figure" and "term" roles; update AXRoleDescription mapping for "feed" role
Summary: AX: Implement support for ARIA "figure" and "term" roles; update AXRoleDescri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
: 151691 171173 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-22 19:12 PDT by Joanmarie Diggs
Modified: 2017-05-01 00:49 PDT (History)
9 users (show)

See Also:

Attachments
Patch (24.32 KB, patch)
2017-04-30 06:32 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2017-04-22 19:12:37 PDT 
According to https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-figure:

WebKitGtk: ROLE_PANEL + object attribute xml-roles:figure
Mac: AXRole: AXGroup, AXSubrole: <nil>, AXRoleDescription: 'figure'
Comment 1 Radar WebKit Bug Importer 2017-04-22 19:12:54 PDT 
<rdar://problem/31776037>
Comment 2 Joanmarie Diggs 2017-04-30 05:44:38 PDT 
https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-term states:

For Mac:
  AXRole: AXGroup
  AXSubrole: AXTerm
  AXRoleDescription: 'term'

For WebKitGtk:
  ROLE_DESCRIPTION_TERM
  Interfaces: AtkText; AtkHypertext
Comment 3 Joanmarie Diggs 2017-04-30 05:44:55 PDT 
*** Bug 171173 has been marked as a duplicate of this bug. ***
Comment 4 Joanmarie Diggs 2017-04-30 05:47:53 PDT 
As stated in bug 151691 comment 9:

> > Todo: Implement a new 'feedRole' in WebKit, a with macOS platform mapping of:
> > 
> >   AXRole: AXGroup
> >   AXSubrole: AXApplicationGroup
> 
> The above is already done.
> 
> >   AXRoleDescription: 'feed'
> 
> This will need to be done. Currently it is 'group'. Assigning to myself.
> Will do a new patch, along with some other new roles, tomorrow.
> 
> Thanks for the update!
Comment 5 Joanmarie Diggs 2017-04-30 06:32:27 PDT 
Created attachment 308690 [details]
Patch
Comment 6 Joanmarie Diggs 2017-04-30 06:33:57 PDT 
*** Bug 151691 has been marked as a duplicate of this bug. ***
Comment 7 Joanmarie Diggs 2017-04-30 22:04:30 PDT 
Chris: Please review. Thanks!
Comment 8 WebKit Commit Bot 2017-05-01 00:49:27 PDT 
Comment on attachment 308690 [details]
Patch

Clearing flags on attachment: 308690

Committed r216007: <http://trac.webkit.org/changeset/216007>
Comment 9 WebKit Commit Bot 2017-05-01 00:49:28 PDT 
All reviewed patches have been landed.  Closing bug.