Bug 171076 - Split cryptographic digest computation and parsing out of CSP code so it can be reused
Summary: Split cryptographic digest computation and parsing out of CSP code so it can ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks: 148363
  Show dependency tree / graph
 
Reported: 2017-04-20 14:23 PDT by Sam Weinig
Modified: 2017-04-21 15:14 PDT (History)
2 users (show)

See Also:

Attachments
Patch (32.09 KB, patch)
2017-04-20 14:48 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (32.13 KB, patch)
2017-04-20 15:07 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (33.59 KB, patch)
2017-04-20 15:35 PDT, Sam Weinig 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-04-20 14:23:54 PDT 
Split cryptographic digest computation and parsing out of CSP code so it can be reused
Comment 1 Sam Weinig 2017-04-20 14:48:23 PDT 
Created attachment 307640 [details]
Patch
Comment 2 Sam Weinig 2017-04-20 15:07:58 PDT 
Created attachment 307643 [details]
Patch
Comment 3 Sam Weinig 2017-04-20 15:35:12 PDT 
Created attachment 307647 [details]
Patch
Comment 4 Chris Dumez 2017-04-21 13:42:43 PDT 
Comment on attachment 307647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307647&action=review

r=me

> Source/WTF/wtf/text/Base64.h:154
> +WTF_EXPORT_PRIVATE bool base64Decode(const StringView&, SignedOrUnsignedCharVectorAdapter, unsigned options = Base64Default);

We usually take StringView in parameter, rather than const StringView& I believe.

> Source/WTF/wtf/text/Base64.h:192
> +WTF_EXPORT_PRIVATE bool base64URLDecode(const StringView&, SignedOrUnsignedCharVectorAdapter);

ditto.
Comment 5 Sam Weinig 2017-04-21 15:14:10 PDT 
Committed revision 215646.