RESOLVED FIXED 171018
Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...]
https://bugs.webkit.org/show_bug.cgi?id=171018
Summary Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConf...
Brady Eidson
Reported 2017-04-19 15:41:21 PDT
Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...] <rdar://problem/30699851>
Attachments
Patch (20.53 KB, patch)
2017-04-19 16:12 PDT, Brady Eidson
no flags
Brady Eidson
Comment 1 2017-04-19 16:12:07 PDT
Build Bot
Comment 2 2017-04-19 16:13:51 PDT
Attachment 307518 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:173: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:228: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-04-19 17:44:03 PDT
Comment on attachment 307518 [details] Patch Clearing flags on attachment: 307518 Committed r215545: <http://trac.webkit.org/changeset/215545>
WebKit Commit Bot
Comment 4 2017-04-19 17:44:04 PDT
All reviewed patches have been landed. Closing bug.
mitz
Comment 5 2017-04-19 19:32:51 PDT
Comment on attachment 307518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307518&action=review > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192 > + [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) { Should this be using a CompletionHandlerCallChecker like other calls that pass a completion handler to the delegate?
Brady Eidson
Comment 6 2017-04-20 11:31:12 PDT
(In reply to mitz from comment #5) > Comment on attachment 307518 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307518&action=review > > > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192 > > + [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) { > > Should this be using a CompletionHandlerCallChecker like other calls that > pass a completion handler to the delegate? Sure probably
Brady Eidson
Comment 7 2017-04-20 12:09:27 PDT
(In reply to Brady Eidson from comment #6) > (In reply to mitz from comment #5) > > Comment on attachment 307518 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=307518&action=review > > > > > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192 > > > + [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) { > > > > Should this be using a CompletionHandlerCallChecker like other calls that > > pass a completion handler to the delegate? > > Sure probably Doing that over in https://bugs.webkit.org/show_bug.cgi?id=171067
Note You need to log in before you can comment on or make changes to this bug.