Bug 171018 – Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...]

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...]

<rdar://problem/30699851>

[Brady Eidson]

Created attachment 307518 [details]
Patch

[Build Bot]

Attachment 307518 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:79:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:173:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:228:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 307518 [details]
Patch

Clearing flags on attachment: 307518

Committed r215545: <http://trac.webkit.org/changeset/215545>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

Comment on attachment 307518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307518&action=review

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192
> +        [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) {

Should this be using a CompletionHandlerCallChecker like other calls that pass a completion handler to the delegate?

[Brady Eidson]

(In reply to mitz from comment #5)
> Comment on attachment 307518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307518&action=review
> 
> > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192
> > +        [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) {
> 
> Should this be using a CompletionHandlerCallChecker like other calls that
> pass a completion handler to the delegate?

Sure probably

[Brady Eidson]

(In reply to Brady Eidson from comment #6)
> (In reply to mitz from comment #5)
> > Comment on attachment 307518 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=307518&action=review
> > 
> > > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192
> > > +        [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) {
> > 
> > Should this be using a CompletionHandlerCallChecker like other calls that
> > pass a completion handler to the delegate?
> 
> Sure probably

Doing that over in https://bugs.webkit.org/show_bug.cgi?id=171067