Bug 171018 - Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...]
Summary: Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-19 15:41 PDT by Brady Eidson
Modified: 2017-04-20 12:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (20.53 KB, patch)
2017-04-19 16:12 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-04-19 15:41:21 PDT 
Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...]

<rdar://problem/30699851>
Comment 1 Brady Eidson 2017-04-19 16:12:07 PDT 
Created attachment 307518 [details]
Patch
Comment 2 Build Bot 2017-04-19 16:13:51 PDT 
Attachment 307518 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:79:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:173:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:228:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-04-19 17:44:03 PDT 
Comment on attachment 307518 [details]
Patch

Clearing flags on attachment: 307518

Committed r215545: <http://trac.webkit.org/changeset/215545>
Comment 4 WebKit Commit Bot 2017-04-19 17:44:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 mitz 2017-04-19 19:32:51 PDT 
Comment on attachment 307518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307518&action=review

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192
> +        [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) {

Should this be using a CompletionHandlerCallChecker like other calls that pass a completion handler to the delegate?
Comment 6 Brady Eidson 2017-04-20 11:31:12 PDT 
(In reply to mitz from comment #5)
> Comment on attachment 307518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307518&action=review
> 
> > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192
> > +        [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) {
> 
> Should this be using a CompletionHandlerCallChecker like other calls that
> pass a completion handler to the delegate?

Sure probably
Comment 7 Brady Eidson 2017-04-20 12:09:27 PDT 
(In reply to Brady Eidson from comment #6)
> (In reply to mitz from comment #5)
> > Comment on attachment 307518 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=307518&action=review
> > 
> > > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192
> > > +        [(id <WKUIDelegatePrivate>)delegate _webView:m_uiDelegate.m_webView createWebViewWithConfiguration:configuration.get() forNavigationAction:wrapper(apiNavigationAction) windowFeatures:wrapper(apiWindowFeatures) completionHandler:^void(WKWebView *webView) {
> > 
> > Should this be using a CompletionHandlerCallChecker like other calls that
> > pass a completion handler to the delegate?
> 
> Sure probably

Doing that over in https://bugs.webkit.org/show_bug.cgi?id=171067