Bug 171067 - Add CompletionHandlerCallChecker to SPI added in r215545
Summary: Add CompletionHandlerCallChecker to SPI added in r215545
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-20 12:06 PDT by Brady Eidson
Modified: 2017-04-20 13:55 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.08 KB, patch)
2017-04-20 12:08 PDT, Brady Eidson
mitz: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (847.05 KB, application/zip)
2017-04-20 13:31 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-04-20 12:06:51 PDT
Add CompletionHandlerCallChecker to SPI added in r215545

https://trac.webkit.org/changeset/215545/webkit
Comment 1 Brady Eidson 2017-04-20 12:08:44 PDT
Created attachment 307610 [details]
Patch
Comment 2 Build Bot 2017-04-20 12:10:34 PDT
Attachment 307610 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:152:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:152:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2017-04-20 13:31:16 PDT
Comment on attachment 307610 [details]
Patch

Attachment 307610 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3571515

New failing tests:
webrtc/datachannel/bufferedAmountLowThreshold.html
Comment 4 Build Bot 2017-04-20 13:31:17 PDT
Created attachment 307630 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 Brady Eidson 2017-04-20 13:51:32 PDT
(In reply to Build Bot from comment #3)
> Comment on attachment 307610 [details]
> Patch
> 
> Attachment 307610 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/3571515
> 
> New failing tests:
> webrtc/datachannel/bufferedAmountLowThreshold.html

This is definitely not due to this patch.
Comment 6 Brady Eidson 2017-04-20 13:55:00 PDT
https://trac.webkit.org/changeset/215577/webkit