Bug 171067 – Add CompletionHandlerCallChecker to SPI added in r215545

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Add CompletionHandlerCallChecker to SPI added in r215545

https://trac.webkit.org/changeset/215545/webkit

[Brady Eidson]

Created attachment 307610 [details]
Patch

[Build Bot]

Attachment 307610 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:152:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:152:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:192:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 307610 [details]
Patch

Attachment 307610 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3571515

New failing tests:
webrtc/datachannel/bufferedAmountLowThreshold.html

[Build Bot]

Created attachment 307630 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Brady Eidson]

(In reply to Build Bot from comment #3)
> Comment on attachment 307610 [details]
> Patch
> 
> Attachment 307610 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/3571515
> 
> New failing tests:
> webrtc/datachannel/bufferedAmountLowThreshold.html

This is definitely not due to this patch.

[Brady Eidson]

https://trac.webkit.org/changeset/215577/webkit