WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
17098
Replace our broken KURL with Google URL
https://bugs.webkit.org/show_bug.cgi?id=17098
Summary
Replace our broken KURL with Google URL
Eric Seidel (no email)
Reported
2008-01-30 11:41:07 PST
Replace our broken KURL with Google URL Google wrote its own URL parsing library which is used a bunch internally, and looks to be significantly better than KURL. If nothing else, the several hundred unit tests are useful. I don't think KURL even does any cannonicalization (which gurl does).
http://code.google.com/p/google-url/
I think WebKit should just pull in gurl as a dependency. The google coding style is kinda strange, but generally pretty similar to WebKit's own. It might even be published somewhere externally...
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2008-01-30 11:45:18 PST
bug 16799
is an example where (in complex cases) we would require a url parser which could canonicalize urls.
Brett Wilson (Google)
Comment 2
2008-01-30 12:37:35 PST
A pet peeve of mine is that a link to "Apple.com" will not be marked as visited, because the URL is not canonicalized before Safari does a history lookup.
Alexey Proskuryakov
Comment 3
2023-01-09 16:18:54 PST
Our URL class is very different now from what it was in 2008.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug