Bug 17098 - Replace our broken KURL with Google URL
Summary: Replace our broken KURL with Google URL
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://code.google.com/p/google-url/
Keywords:
Depends on:
Blocks: 37641
  Show dependency tree / graph
 
Reported: 2008-01-30 11:41 PST by Eric Seidel (no email)
Modified: 2023-01-09 16:18 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-01-30 11:41:07 PST 
Replace our broken KURL with Google URL

Google wrote its own URL parsing library which is used a bunch internally, and looks to be significantly better than KURL.  If nothing else, the several hundred unit tests are useful.  I don't think KURL even does any cannonicalization (which gurl does).

http://code.google.com/p/google-url/

I think WebKit should just pull in gurl as a dependency.  The google coding style is kinda strange, but generally pretty similar to WebKit's own.  It might even be published somewhere externally...
Comment 1 Eric Seidel (no email) 2008-01-30 11:45:18 PST 
bug 16799 is an example where (in complex cases) we would require a url parser which could canonicalize urls.
Comment 2 Brett Wilson (Google) 2008-01-30 12:37:35 PST 
A pet peeve of mine is that a link to "Apple.com" will not be marked as visited, because the URL is not canonicalized before Safari does a history lookup.
Comment 3 Alexey Proskuryakov 2023-01-09 16:18:54 PST 
Our URL class is very different now from what it was in 2008.