Bug 170953 – [mac-wk1 Debug] LayoutTest http/tests/inspector/network/resource-sizes-network.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Ryan Haddad]

LayoutTest http/tests/inspector/network/resource-sizes-network.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r215460%20(622)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fresource-sizes-network.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/resource-sizes-network-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/resource-sizes-network-actual.txt
@@ -140,7 +140,9 @@
 PASS: responseSource should be Symbol(network).
 PASS: estimatedNetworkEncodedSize should be exactly 28 bytes.
 PASS: estimatedTotalTransferSize should be >= (encoded body size + headers).
-PASS: size should be exactly 28 bytes.
+FAIL: size should be exactly 28 bytes.
+    Expected: 28
+    Actual: NaN
 FAIL: networkEncodedSize should be exactly 28 bytes.
     Expected: 28
     Actual: NaN

[Joseph Pecoraro]

Arg, we should just mark this test as flakey on WebKit 1 then. (mac-wk1).

I should be able to do that.

[Joseph Pecoraro]

Marked as flakey on WebKit 1:
https://trac.webkit.org/changeset/215478/webkit

[Ryan Haddad]

Just saw this test fail on mac-wk2: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/629

[Joseph Pecoraro]

Okay I'll take a look today to see if I can unflake this. I think I just need to wait slightly longer for the load to complete in fetch.

[Joseph Pecoraro]

Created attachment 308198 [details]
[PATCH] Proposed Fix

I was able to occasionally see failures on my laptop. With this change I didn't see such failures. On my Mac Pro I never saw failures, so this is still somewhat speculative.

[Joseph Pecoraro]

Comment on attachment 308198 [details]
[PATCH] Proposed Fix

Err, I have to update to unskip the test that has since been marked flakey.

[Joseph Pecoraro]

*** Bug 170971 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

Created attachment 308204 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 308204 [details]
[PATCH] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 308204 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 308204

Committed r215794: <http://trac.webkit.org/changeset/215794>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.