Bug 170953 - [mac-wk1 Debug] LayoutTest http/tests/inspector/network/resource-sizes-network.html is a flaky failure
Summary: [mac-wk1 Debug] LayoutTest http/tests/inspector/network/resource-sizes-networ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 170971 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-18 10:22 PDT by Ryan Haddad
Modified: 2017-04-25 23:38 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.02 KB, patch)
2017-04-25 20:22 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (3.81 KB, patch)
2017-04-25 20:50 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-04-18 10:22:14 PDT 
LayoutTest http/tests/inspector/network/resource-sizes-network.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r215460%20(622)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fresource-sizes-network.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/resource-sizes-network-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/resource-sizes-network-actual.txt
@@ -140,7 +140,9 @@
 PASS: responseSource should be Symbol(network).
 PASS: estimatedNetworkEncodedSize should be exactly 28 bytes.
 PASS: estimatedTotalTransferSize should be >= (encoded body size + headers).
-PASS: size should be exactly 28 bytes.
+FAIL: size should be exactly 28 bytes.
+    Expected: 28
+    Actual: NaN
 FAIL: networkEncodedSize should be exactly 28 bytes.
     Expected: 28
     Actual: NaN
Comment 1 Joseph Pecoraro 2017-04-18 13:27:37 PDT 
Arg, we should just mark this test as flakey on WebKit 1 then. (mac-wk1).

I should be able to do that.
Comment 2 Joseph Pecoraro 2017-04-18 13:38:16 PDT 
Marked as flakey on WebKit 1:
https://trac.webkit.org/changeset/215478/webkit
Comment 3 Ryan Haddad 2017-04-20 09:49:25 PDT 
Just saw this test fail on mac-wk2: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/629
Comment 4 Joseph Pecoraro 2017-04-20 11:41:17 PDT 
Okay I'll take a look today to see if I can unflake this. I think I just need to wait slightly longer for the load to complete in fetch.
Comment 5 Joseph Pecoraro 2017-04-25 20:22:32 PDT 
Created attachment 308198 [details]
[PATCH] Proposed Fix

I was able to occasionally see failures on my laptop. With this change I didn't see such failures. On my Mac Pro I never saw failures, so this is still somewhat speculative.
Comment 6 Joseph Pecoraro 2017-04-25 20:24:35 PDT 
Comment on attachment 308198 [details]
[PATCH] Proposed Fix

Err, I have to update to unskip the test that has since been marked flakey.
Comment 7 Joseph Pecoraro 2017-04-25 20:47:59 PDT 
*** Bug 170971 has been marked as a duplicate of this bug. ***
Comment 8 Joseph Pecoraro 2017-04-25 20:50:25 PDT 
Created attachment 308204 [details]
[PATCH] Proposed Fix
Comment 9 BJ Burg 2017-04-25 23:09:16 PDT 
Comment on attachment 308204 [details]
[PATCH] Proposed Fix

r=me
Comment 10 WebKit Commit Bot 2017-04-25 23:38:41 PDT 
Comment on attachment 308204 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 308204

Committed r215794: <http://trac.webkit.org/changeset/215794>
Comment 11 WebKit Commit Bot 2017-04-25 23:38:42 PDT 
All reviewed patches have been landed.  Closing bug.