WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
170900
[selectors4] css/selectors4/focus-within-006.html test from WPT is failing
https://bugs.webkit.org/show_bug.cgi?id=170900
Summary
[selectors4] css/selectors4/focus-within-006.html test from WPT is failing
Manuel Rego Casasnovas
Reported
2017-04-17 01:34:59 PDT
The problem with this test is that it uses an INPUT which is focused in JavaScript: focusme.focus(); In WebKit this causes the text of the INPUT to be selected, which doesn't happen on Chrome and Firefox. That's the reason why this test is failing. Probably the solution would be to change the test upstream directly on WTP to use something different and avoid this difference. Just reporting this bug to track the issue as I'm importing the WTP test suite.
Attachments
Patch
(6.40 KB, patch)
2017-05-12 00:24 PDT
,
Manuel Rego Casasnovas
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1
2017-04-18 04:29:43 PDT
On top of the difference when you focus the input between WebKit, where the text gets selected, and other browsers. We've more problems with this test, as despite it has "all: initial" the input element still uses a different font in WebKit:
http://jsbin.com/pedixiy/edit?html,css,output
Manuel Rego Casasnovas
Comment 2
2017-04-18 05:10:05 PDT
(In reply to Manuel Rego Casasnovas from
comment #1
)
> On top of the difference when you focus the input between WebKit, where the > text gets selected, and other browsers. > We've more problems with this test, as despite it has "all: initial" the > input element still uses a different font in WebKit: >
http://jsbin.com/pedixiy/edit?html,css,output
This problem is related to "font-family: intial" and the differences between form elements and regular ones in WebKit (see
bug #170900
).
Manuel Rego Casasnovas
Comment 3
2017-04-24 00:15:21 PDT
(In reply to Manuel Rego Casasnovas from
comment #2
)
> This problem is related to "font-family: intial" and the differences between > form elements and regular ones in WebKit (see
bug #170900
).
This should point to
bug #168258
.
Manuel Rego Casasnovas
Comment 4
2017-05-04 07:19:21 PDT
To fix this I'm proposing a modification of this test upstream:
https://github.com/w3c/web-platform-tests/pull/5786
Once it's merged I'll import it and close this.
Manuel Rego Casasnovas
Comment 5
2017-05-12 00:24:07 PDT
Created
attachment 309877
[details]
Patch
WebKit Commit Bot
Comment 6
2017-05-12 02:43:47 PDT
Comment on
attachment 309877
[details]
Patch Clearing flags on attachment: 309877 Committed
r216756
: <
http://trac.webkit.org/changeset/216756
>
WebKit Commit Bot
Comment 7
2017-05-12 02:43:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug