Bug 170898 – [selectors4] Import W3C Test Suite

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Manuel Rego Casasnovas]

It'd be nice to import this test suite as it spots an issue on current :focus-within implementation.

The suite is at WPT repo:
https://github.com/w3c/web-platform-tests/tree/master/css/selectors4

[Manuel Rego Casasnovas]

Created attachment 307262 [details]
Patch

[Build Bot]

Comment on attachment 307262 [details]
Patch

Attachment 307262 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3550192

New failing tests:
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-003.html
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-001.html
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004.html
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005.html
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-002.html

[Build Bot]

Created attachment 307264 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 307262 [details]
Patch

Attachment 307262 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3550199

New failing tests:
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-003.html
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-001.html
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004.html
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005.html
imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-002.html

[Build Bot]

Created attachment 307265 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Manuel Rego Casasnovas]

It seems the Mac EWSs are failing only in the Shadow DOM tests:

(In reply to Build Bot from comment #2)
> New failing tests:
> imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-003.html
> imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-001.html
> imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004.html
> imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005.html
> imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-002.html

I've tried to reproduce the failure on a macpro, but I couldn't manage to do it.
In my case these tests are passing properly, also "mac-wk2" EWS is green.

Could someone give me any hint on what's going on here? Thanks!

[youenn fablet]

Not sure why they fail.
You can add specific mac-wk1 [Pass Failure] TestExpectations for these I guess.

[Manuel Rego Casasnovas]

Created attachment 307357 [details]
Patch for landing

[Manuel Rego Casasnovas]

(In reply to youenn fablet from comment #7)
> Not sure why they fail.
> You can add specific mac-wk1 [Pass Failure] TestExpectations for these I
> guess.

It seems a timing issue, I've added more info in bug #170935.
I can reproduce the issue now passing "-1" to run-webkit-tests in order to use WK1.
Anyway I'll skip them for the first import and then work on getting them unskipped.

Thanks for the review.

[WebKit Commit Bot]

Comment on attachment 307357 [details]
Patch for landing

Clearing flags on attachment: 307357

Committed r215457: <http://trac.webkit.org/changeset/215457>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

It looks like the tests should have been marked as 'ImageOnlyFailure' for mac-wk1. I took care of that in https://trac.webkit.org/changeset/215464/webkit.

[Manuel Rego Casasnovas]

(In reply to Ryan Haddad from comment #12)
> It looks like the tests should have been marked as 'ImageOnlyFailure' for
> mac-wk1. I took care of that in
> https://trac.webkit.org/changeset/215464/webkit.

Oops, sorry about that. Thanks for fixing it.