Bug 170721 – REGRESSION(r215211): [GTK] Lots of image related tests are crashing, causing the test bot to exit early

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Miguel Gomez]

There seems to be an infinite loop created by r215211.

[Miguel Gomez]

Created attachment 306791 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 306791 [details]
Patch

Clearing flags on attachment: 306791

Committed r215224: <http://trac.webkit.org/changeset/215224>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Said Abou-Hallawa]

Comment on attachment 306791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306791&action=review

> Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp:61
> +    if (ImageDecoder::encodedDataStatus() < EncodedDataStatus::SizeAvailable)

Alternately you could change the ImageDecoder::isSizeAvailable() in platform/image-decoders/ImageDecoder.h to force calling the base class function:

<< bool isSizeAvailable() { return encodedDataStatus() >= EncodedDataStatus::SizeAvailable; }
>> bool isSizeAvailable() { return ImageDecoder::encodedDataStatus() >= EncodedDataStatus::SizeAvailable; }

This should avoid making the same change in six different source files. And this is the correct behavior since isSizeAvailable() tells the status of the encoded data before doing any decoding.