Bug 170410 - REGRESSION: fast/images/animated-gif-webkit-transform.html is flaky
Summary: REGRESSION: fast/images/animated-gif-webkit-transform.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-03 12:48 PDT by Alexey Proskuryakov
Modified: 2017-06-08 15:12 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.10 KB, patch)
2017-06-08 11:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-04-03 12:48:45 PDT
fast/images/animated-gif-webkit-transform.html has become flaky on multiple bots recently (2017-03-28).

@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS isFirstImagePaused() is false
+FAIL isFirstImagePaused() should be false. Was true.
 PASS isSecondImagePaused() became true
 PASS isFirstImagePaused() is false
 Translating images left so that first image is no longer visible, but second image is.
Comment 1 Radar WebKit Bug Importer 2017-04-03 12:52:09 PDT
<rdar://problem/31409381>
Comment 3 Ryan Haddad 2017-04-04 10:53:22 PDT
Marked test as flaky in https://trac.webkit.org/changeset/214884/webkit
Comment 4 Ryan Haddad 2017-06-08 10:54:47 PDT
According to the flakiness dashboard, this test is no longer flaky.
Comment 5 Chris Dumez 2017-06-08 10:59:24 PDT
I can reproduce with:
Tools/Scripts/run-webkit-tests --repeat-each=200 fast/images/animated-gif-webkit-transform.html -gf --child-processes=10

(Need to update TestExpections first as the test has been marked as flaky)

Result:
--- /Volumes/Data/cdumez/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/fast/images/animated-gif-webkit-transform-expected.txt
+++ /Volumes/Data/cdumez/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/fast/images/animated-gif-webkit-transform-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


-PASS isFirstImagePaused() is false
+FAIL isFirstImagePaused() should be false. Was true.
 PASS isSecondImagePaused() became true
 PASS isFirstImagePaused() is false
 Translating images left so that first image is no longer visible, but second image is.
Comment 6 Chris Dumez 2017-06-08 11:02:37 PDT
I have a fix. Will upload after lunch.
Comment 7 Chris Dumez 2017-06-08 11:10:22 PDT
Created attachment 312324 [details]
Patch
Comment 8 Chris Dumez 2017-06-08 15:12:36 PDT
Comment on attachment 312324 [details]
Patch

Clearing flags on attachment: 312324

Committed r217950: <http://trac.webkit.org/changeset/217950>
Comment 9 Chris Dumez 2017-06-08 15:12:39 PDT
All reviewed patches have been landed.  Closing bug.