LayoutTest fast/images/animated-image-different-dest-size.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r214487%20(231)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fimages%2Fanimated-image-different-dest-size.html The image diff shows the two rightmost squares are green, but the expected color is blue.
This test was just added with http://trac.webkit.org/changeset/214450
Flaky on Mac WK2 bots. We should have rolled back the change, but it's probably too late now. Marked as flaky in http://trac.webkit.org/r214673
rdar://problem/31373038
Corrected TestExpectations entry in http://trac.webkit.org/r214675 (forgot that image failures need to be marked as ImageOnlyFailure).
Created attachment 312253 [details] Patch
Created attachment 312307 [details] Patch
I verified the fix by removing the test form TestExpectations and running the command: run-webkit-tests --debug --repeat-each=200 LayoutTests/fast/images/animated-image-different-dest-size.html -gf --child-processes=10
Comment on attachment 312307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312307&action=review > LayoutTests/fast/images/animated-image-different-dest-size.html:50 > + function loadImage(element, src, canvasIds, frameCount) { > return new Promise((resolve) => { > let image = new Image; > image.onload = (() => { Now you have an image and an image element. That doesn't make much sense.
Created attachment 312363 [details] Patch
Created attachment 312364 [details] Patch
Comment on attachment 312364 [details] Patch Attachment 312364 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3897035 New failing tests: svg/animations/svglength-element-removed-crash.svg
Created attachment 312371 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Created attachment 312473 [details] Patch
Comment on attachment 312371 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The iOS-sim bot failed because svg/animations/svglength-element-removed-crash.svg is flaky. It confuses the EWS by failing consistently with the attached patch and pass without it although it should not have any effect on the result of this test.
Comment on attachment 312473 [details] Patch Clearing flags on attachment: 312473 Committed r218019: <http://trac.webkit.org/changeset/218019>
All reviewed patches have been landed. Closing bug.