Bug 170365 - REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
Summary: REGRESSION (r202472): Data Detection overwrites existing links in detected ra...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on: 161967
Blocks:
  Show dependency treegraph
 
Reported: 2017-03-31 15:07 PDT by Andy Estes
Modified: 2017-04-14 13:52 PDT (History)
9 users (show)

See Also:


Attachments
Patch (4.81 KB, patch)
2017-03-31 15:24 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (4.51 KB, patch)
2017-04-05 00:44 PDT, Andy Estes
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-03-31 15:07:14 PDT
REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
Comment 1 Andy Estes 2017-03-31 15:11:43 PDT
rdar://problem/29205721
Comment 2 Andy Estes 2017-03-31 15:24:18 PDT
Created attachment 306019 [details]
Patch
Comment 3 WebKit Commit Bot 2017-03-31 16:33:27 PDT
Comment on attachment 306019 [details]
Patch

Clearing flags on attachment: 306019

Committed r214697: <http://trac.webkit.org/changeset/214697>
Comment 4 WebKit Commit Bot 2017-03-31 16:33:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2017-04-01 18:57:22 PDT
Rolled back in r214722.
Comment 7 Andy Estes 2017-04-03 13:51:26 PDT
(In reply to Alexey Proskuryakov from comment #5)
> WebKit2.DataDetectionReferenceDate has started to time out super frequently
> after the change.
> 
> https://build.webkit.org/builders/
> Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/311/steps/
> run-api-tests/logs/stdio
> 
> https://build.webkit.org/builders/
> Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/354/steps/
> run-api-tests/logs/stdio

The test was disabled before this change. I re-enabled it because it passed for me locally, but I guess whatever caused it to be disabled in the first place is still an issue.
Comment 8 Andy Estes 2017-04-04 23:07:18 PDT
I have a fix for the existing test failure here: https://bugs.webkit.org/show_bug.cgi?id=170496
Comment 9 Andy Estes 2017-04-05 00:44:14 PDT
Created attachment 306267 [details]
Patch
Comment 10 WebKit Commit Bot 2017-04-05 01:24:51 PDT
Comment on attachment 306267 [details]
Patch

Clearing flags on attachment: 306267

Committed r214937: <http://trac.webkit.org/changeset/214937>
Comment 11 WebKit Commit Bot 2017-04-05 01:24:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Ryan Haddad 2017-04-05 12:43:09 PDT
Reverted r214937 for reason:

This change broke an internal build.

Committed r214962: <http://trac.webkit.org/changeset/214962>
Comment 13 Ryan Haddad 2017-04-05 13:15:09 PDT
Reverted r214962 for reason:

Roll r214937 back in because it wasn't at fault for the build breakage.

Committed r214963: <http://trac.webkit.org/changeset/214963>
Comment 14 Andy Estes 2017-04-14 13:45:15 PDT
Reopening now that bug #161967 is resolved again.
Comment 15 WebKit Commit Bot 2017-04-14 13:47:00 PDT
Comment on attachment 306267 [details]
Patch

Rejecting attachment 306267 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 306267, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
le Source/WebCore/editing/cocoa/DataDetection.mm.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm
Hunk #1 FAILED at 60.
Hunk #2 succeeded at 90 with fuzz 2 (offset 9 lines).
1 out of 2 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3535562
Comment 16 Andy Estes 2017-04-14 13:52:48 PDT
Nevermind, Ryan rolled this back in.