Bug 170365 – REGRESSION (r202472): Data Detection overwrites existing links in detected ranges

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

REGRESSION (r202472): Data Detection overwrites existing links in detected ranges

[Andy Estes]

rdar://problem/29205721

[Andy Estes]

Created attachment 306019 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 306019 [details]
Patch

Clearing flags on attachment: 306019

Committed r214697: <http://trac.webkit.org/changeset/214697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

WebKit2.DataDetectionReferenceDate has started to time out super frequently after the change.

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/311/steps/run-api-tests/logs/stdio

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/354/steps/run-api-tests/logs/stdio

[Alexey Proskuryakov]

Rolled back in r214722.

[Andy Estes]

(In reply to Alexey Proskuryakov from comment #5)
> WebKit2.DataDetectionReferenceDate has started to time out super frequently
> after the change.
> 
> https://build.webkit.org/builders/
> Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/311/steps/
> run-api-tests/logs/stdio
> 
> https://build.webkit.org/builders/
> Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/354/steps/
> run-api-tests/logs/stdio

The test was disabled before this change. I re-enabled it because it passed for me locally, but I guess whatever caused it to be disabled in the first place is still an issue.

[Andy Estes]

I have a fix for the existing test failure here: https://bugs.webkit.org/show_bug.cgi?id=170496

[Andy Estes]

Created attachment 306267 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 306267 [details]
Patch

Clearing flags on attachment: 306267

Committed r214937: <http://trac.webkit.org/changeset/214937>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

Reverted r214937 for reason:

This change broke an internal build.

Committed r214962: <http://trac.webkit.org/changeset/214962>

[Ryan Haddad]

Reverted r214962 for reason:

Roll r214937 back in because it wasn't at fault for the build breakage.

Committed r214963: <http://trac.webkit.org/changeset/214963>

[Andy Estes]

Reopening now that bug #161967 is resolved again.

[WebKit Commit Bot]

Comment on attachment 306267 [details]
Patch

Rejecting attachment 306267 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 306267, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
le Source/WebCore/editing/cocoa/DataDetection.mm.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm
Hunk #1 FAILED at 60.
Hunk #2 succeeded at 90 with fuzz 2 (offset 9 lines).
1 out of 2 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3535562

[Andy Estes]

Nevermind, Ryan rolled this back in.