Bug 170496 - [iOS] DDQueryOffset is the wrong size in Public SDK builds
Summary: [iOS] DDQueryOffset is the wrong size in Public SDK builds
Status: RESOLVED DUPLICATE of bug 161967
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-04 23:06 PDT by Andy Estes
Modified: 2017-04-05 00:09 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2017-04-04 23:16 PDT, Andy Estes 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-04-04 23:06:52 PDT 
[iOS] DDQueryOffset is the wrong size in Public SDK builds
Comment 1 Andy Estes 2017-04-04 23:16:48 PDT 
Created attachment 306262 [details]
Patch
Comment 2 Build Bot 2017-04-04 23:19:38 PDT 
Attachment 306262 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:109:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:110:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2017-04-04 23:23:14 PDT 
I think this might be the cause of bug 167594!
Comment 4 Alexey Proskuryakov 2017-04-04 23:23:31 PDT 
Comment on attachment 306262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306262&action=review

Neat.

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=170496

https://bugs.webkit.org/show_bug.cgi?id=161967 ?

> Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:120
> +static_assert(sizeof(DDQueryOffset) == 8, "DDQueryOffset is defined to be 8 bytes in the Public SDK build.");

The message doesn't sound quite right - the assert can potentially fail in non-public build too (and that's a good thing).
Comment 5 Andy Estes 2017-04-04 23:30:44 PDT 
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 306262 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306262&action=review
> 
> Neat.
> 
> > Source/WebCore/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=170496
> 
> https://bugs.webkit.org/show_bug.cgi?id=161967 ?
> 
> > Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:120
> > +static_assert(sizeof(DDQueryOffset) == 8, "DDQueryOffset is defined to be 8 bytes in the Public SDK build.");
> 
> The message doesn't sound quite right - the assert can potentially fail in
> non-public build too (and that's a good thing).

The message isn't saying in which build the assertion is failing, it's saying what size our SPI header defines the struct to be in the Public SDK build; it's just restating the assertion in English. I'll reword it as an error.

Thanks for the review!
Comment 6 Andy Estes 2017-04-04 23:41:45 PDT 

*** This bug has been marked as a duplicate of bug 167594 ***
Comment 7 Andy Estes 2017-04-04 23:42:10 PDT 

*** This bug has been marked as a duplicate of bug 161967 ***