Bug 170335 - REGRESSION(r214503): [GTK] Test canvas/philip/tests/2d.pattern.animated.gif.html started to fail after r214503
Summary: REGRESSION(r214503): [GTK] Test canvas/philip/tests/2d.pattern.animated.gif.h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-03-31 03:40 PDT by Carlos Garcia Campos
Modified: 2021-02-16 02:27 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2021-02-16 01:20 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-03-31 03:40:58 PDT 
This is caused by the call to startAnimation added to CachedImage::didAddClient(). Before r214503 the gif animation never really started, so we always ended up drawing the first frame, but now the animation is started and the second frame is rendered (the red one). I have no idea why this doesn't fail in apple ports, though.
Comment 1 Carlos Garcia Campos 2017-03-31 05:08:49 PDT 
Test svg/animations/animated-svg-image-outside-viewport-paused.html also fails

-PASS Basic video stats 
+FAIL Basic video stats promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'senderParameters.encodings[0].fec')"
Comment 2 Chris Lord 2021-02-16 01:11:58 PST 
Looks like this is fixed now, will attach a patch to remove the expected fail.
Comment 3 Chris Lord 2021-02-16 01:20:15 PST 
Created attachment 420436 [details]
Patch
Comment 4 Chris Lord 2021-02-16 01:21:05 PST 
Comment on attachment 420436 [details]
Patch

For reference, this was fixed by r272776 (bug 221637).
Comment 5 EWS 2021-02-16 02:27:03 PST 
Committed r272899: <https://commits.webkit.org/r272899>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420436 [details].