Bug 221637 - Make Pattern hold a NativeImage instead of an Image
Summary: Make Pattern hold a NativeImage instead of an Image
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 219468
  Show dependency tree / graph
 
Reported: 2021-02-09 15:17 PST by Said Abou-Hallawa
Modified: 2021-02-16 19:49 PST (History)
17 users (show)

See Also:

Attachments
Patch (43.63 KB, patch)
2021-02-09 16:14 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (43.87 KB, patch)
2021-02-09 16:35 PST, Said Abou-Hallawa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (43.93 KB, patch)
2021-02-09 17:01 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (43.93 KB, patch)
2021-02-09 17:25 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (43.92 KB, patch)
2021-02-09 18:56 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (58.94 KB, patch)
2021-02-11 21:45 PST, Said Abou-Hallawa 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch (59.04 KB, patch)
2021-02-12 00:07 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-02-09 15:17:43 PST 
This is step towards the fix of bug 219468.

This will make caching the Pattern data in the GPUP straightforward since we need to cache the NativeImage and send the pattern data.
Comment 1 Said Abou-Hallawa 2021-02-09 16:14:43 PST 
Created attachment 419783 [details]
Patch
Comment 2 Said Abou-Hallawa 2021-02-09 16:35:37 PST 
Created attachment 419784 [details]
Patch
Comment 3 Said Abou-Hallawa 2021-02-09 17:01:45 PST 
Created attachment 419787 [details]
Patch
Comment 4 Said Abou-Hallawa 2021-02-09 17:25:30 PST 
Created attachment 419793 [details]
Patch
Comment 5 Said Abou-Hallawa 2021-02-09 18:56:46 PST 
Created attachment 419803 [details]
Patch
Comment 6 Said Abou-Hallawa 2021-02-11 21:45:45 PST 
Created attachment 420097 [details]
Patch
Comment 7 Simon Fraser (smfr) 2021-02-11 23:07:28 PST 
Comment on attachment 420097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420097&action=review

> Source/WebCore/platform/graphics/Pattern.h:70
> +        bool repeatX;
> +        bool repeatY;
> +        AffineTransform patternSpaceTransform;

Putting the bools after the transform will eliminate some padding.
Comment 8 Said Abou-Hallawa 2021-02-12 00:07:25 PST 
Created attachment 420101 [details]
Patch
Comment 9 EWS 2021-02-12 01:10:44 PST 
Committed r272776: <https://commits.webkit.org/r272776>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420101 [details].
Comment 10 Radar WebKit Bug Importer 2021-02-12 01:11:15 PST 
<rdar://problem/74268391>