Bug 170223 – [WebRTC] Update test RTCPeerConnection-overloaded-operations-params.html after r214441

• Status: REOPENED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

After r214441 <https://trac.webkit.org/changeset/214441/webkit> addIceCandidate(null) doesn't throw an error.
This seems correct according to the last version of the spec as discussed on bug 170146 and on bug 170118.

The test RTCPeerConnection-overloaded-operations-params.html needs to be updated to this new behaviour.

Note that this test is currently skipped on all ports but WebKitGTK+ (OpenWebRTC).

[Carlos Alberto Lopez Perez]

Created attachment 305696 [details]
Patch

[youenn fablet]

Comment on attachment 305696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305696&action=review

> LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt:82
> +PASS promise pc.addIceCandidate(null) did not reject with TypeError.

This one is not really an overloaded and is covered elsewhere I think. But this is ok having it here.

[Carlos Alberto Lopez Perez]

Thanks for the review.

One note, after r214527 <https://trac.webkit.org/changeset/214527> the expectation has changed to:

--- a/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt
+++ b/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt
@@ -50,7 +50,7 @@ PASS promise pc.createAnswer(emptyFunc, emptyFunc, 1) rejected with TypeError: A
 PASS promise pc.setLocalDescription(desc) did not reject with TypeError.
 PASS promise pc.setLocalDescription(desc, emptyFunc, emptyFunc) did not reject with TypeError.
 *** desc is not optional
-PASS promise pc.setLocalDescription() rejected with TypeError: Not enough arguments
+FAIL promise pc.setLocalDescription() rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setLocalDescription must be an instance of RTCSessionDescription; expected reason TypeError: Not enough arguments
 *** desc is not nullable
 PASS promise pc.setLocalDescription(null) rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setLocalDescription must be an instance of RTCSessionDescription
 PASS promise pc.setLocalDescription(null, emptyFunc, emptyFunc) rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setLocalDescription must be an instance of RTCSessionDescription
@@ -65,7 +65,7 @@ PASS promise pc.setLocalDescription(1, emptyFunc, emptyFunc) rejected with TypeE
 PASS promise pc.setRemoteDescription(desc) did not reject with TypeError.
 PASS promise pc.setRemoteDescription(desc, emptyFunc, emptyFunc) did not reject with TypeError.
 *** desc is not optional
-PASS promise pc.setRemoteDescription() rejected with TypeError: Not enough arguments
+FAIL promise pc.setRemoteDescription() rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setRemoteDescription must be an instance of RTCSessionDescription; expected reason TypeError: Not enough arguments
 *** desc is not nullable
 PASS promise pc.setRemoteDescription(null) rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setRemoteDescription must be an instance of RTCSessionDescription
 PASS promise pc.setRemoteDescription(null, emptyFunc, emptyFunc) rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setRemoteDescription must be an instance of RTCSessionDescription


I'm landing the last version of the expectation.

[Carlos Alberto Lopez Perez]

Committed r214533: <http://trac.webkit.org/changeset/214533>

[Carlos Alberto Lopez Perez]

(In reply to Carlos Alberto Lopez Perez from comment #3)
> Thanks for the review.
> 
> One note, after r214527 <https://trac.webkit.org/changeset/214527> the
> expectation has changed to:
> 
> ---
> a/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-
> params-expected.txt
> +++
> b/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-
> params-expected.txt
> @@ -50,7 +50,7 @@ PASS promise pc.createAnswer(emptyFunc, emptyFunc, 1)
> rejected with TypeError: A
>  PASS promise pc.setLocalDescription(desc) did not reject with TypeError.
>  PASS promise pc.setLocalDescription(desc, emptyFunc, emptyFunc) did not
> reject with TypeError.
>  *** desc is not optional
> -PASS promise pc.setLocalDescription() rejected with TypeError: Not enough
> arguments
> +FAIL promise pc.setLocalDescription() rejected with TypeError: Argument 1
> ('description') to RTCPeerConnection.setLocalDescription must be an instance
> of RTCSessionDescription; expected reason TypeError: Not enough arguments
>  *** desc is not nullable
>  PASS promise pc.setLocalDescription(null) rejected with TypeError: Argument
> 1 ('description') to RTCPeerConnection.setLocalDescription must be an
> instance of RTCSessionDescription
>  PASS promise pc.setLocalDescription(null, emptyFunc, emptyFunc) rejected
> with TypeError: Argument 1 ('description') to
> RTCPeerConnection.setLocalDescription must be an instance of
> RTCSessionDescription
> @@ -65,7 +65,7 @@ PASS promise pc.setLocalDescription(1, emptyFunc,
> emptyFunc) rejected with TypeE
>  PASS promise pc.setRemoteDescription(desc) did not reject with TypeError.
>  PASS promise pc.setRemoteDescription(desc, emptyFunc, emptyFunc) did not
> reject with TypeError.
>  *** desc is not optional
> -PASS promise pc.setRemoteDescription() rejected with TypeError: Not enough
> arguments
> +FAIL promise pc.setRemoteDescription() rejected with TypeError: Argument 1
> ('description') to RTCPeerConnection.setRemoteDescription must be an
> instance of RTCSessionDescription; expected reason TypeError: Not enough
> arguments
>  *** desc is not nullable
>  PASS promise pc.setRemoteDescription(null) rejected with TypeError:
> Argument 1 ('description') to RTCPeerConnection.setRemoteDescription must be
> an instance of RTCSessionDescription
>  PASS promise pc.setRemoteDescription(null, emptyFunc, emptyFunc) rejected
> with TypeError: Argument 1 ('description') to
> RTCPeerConnection.setRemoteDescription must be an instance of
> RTCSessionDescription
> 
> 
> I'm landing the last version of the expectation.

aggh... i overlook detected the fail strings