Bug 170118 – addIceCandidate should not throw if passed null or undefined

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

This should just indicate end of ICE candidate addition.

[youenn fablet]

Created attachment 305475 [details]
Patch

[Build Bot]

Comment on attachment 305475 [details]
Patch

Attachment 305475 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3418452

New failing tests:
imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl.html
webrtc/video-remote-mute.html
webrtc/audio-replace-track.html
webrtc/release-after-getting-track.html
webrtc/video-replace-track-to-null.html
webrtc/audio-peer-connection-webaudio.html
webrtc/peer-connection-audio-mute.html
webrtc/video-mediastreamtrack-stats.html
webrtc/video-with-receiver.html
webrtc/video-mute.html
webrtc/connection-state.html

[Build Bot]

Created attachment 305479 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 305485 [details]
Patch

[Eric Carlson]

Comment on attachment 305485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305485&action=review

> LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:82
> +FAIL RTCPeerConnection interface: calling addIceCandidate([object Object],[object Object]) on pc with too few arguments must throw TypeError assert_unreached: Should have rejected: undefined Reached unreachable code

is this expected?

[youenn fablet]

(In reply to Eric Carlson from comment #5)
> Comment on attachment 305485 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305485&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:82
> > +FAIL RTCPeerConnection interface: calling addIceCandidate([object Object],[object Object]) on pc with too few arguments must throw TypeError assert_unreached: Should have rejected: undefined Reached unreachable code
> 
> is this expected?

I think webidl parser should be updated and/or the test so that it understands that undefined turns into an empty RTCIceCandidateInit object.

[WebKit Commit Bot]

Comment on attachment 305485 [details]
Patch

Clearing flags on attachment: 305485

Committed r214441: <http://trac.webkit.org/changeset/214441>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Comment on attachment 305485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305485&action=review

>>> LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:82
>>> +FAIL RTCPeerConnection interface: calling addIceCandidate([object Object],[object Object]) on pc with too few arguments must throw TypeError assert_unreached: Should have rejected: undefined Reached unreachable code
>> 
>> is this expected?
> 
> I think webidl parser should be updated and/or the test so that it understands that undefined turns into an empty RTCIceCandidateInit object.

This one looks real to me. You are no longer throwing a TypeError when calling addIceCandidate() without a parameter. As per Web IDL, I think we should. addIceCandidate(undefined) is not the same as addIceCandidate().

[youenn fablet]

Filed bug 170146 to fix both not-throwing and function-length failures