Bug 170083 - Add font-optical-sizing to CSSComputedStyleDeclaration
Summary: Add font-optical-sizing to CSSComputedStyleDeclaration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on: 168895
Blocks: 162815
  Show dependency treegraph
 
Reported: 2017-03-24 16:19 PDT by Myles C. Maxfield
Modified: 2017-03-25 00:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.55 KB, patch)
2017-03-24 16:19 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch for committing (7.70 KB, patch)
2017-03-24 19:40 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch for committing (7.80 KB, patch)
2017-03-24 19:42 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (928.79 KB, application/zip)
2017-03-24 20:48 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.01 MB, application/zip)
2017-03-24 20:52 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.72 MB, application/zip)
2017-03-24 20:58 PDT, Build Bot
no flags Details
Patch for committing (24.59 KB, patch)
2017-03-24 21:16 PDT, Myles C. Maxfield
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (903.42 KB, application/zip)
2017-03-24 22:50 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-03-24 16:19:02 PDT
Add font-optical-sizing to CSSComputedStyleDeclaration
Comment 1 Myles C. Maxfield 2017-03-24 16:19:57 PDT
Created attachment 305334 [details]
Patch
Comment 2 Joseph Pecoraro 2017-03-24 16:21:52 PDT
Comment on attachment 305334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305334&action=review

r=me

> LayoutTests/fast/text/variations/optical-sizing.html:34
> +var x = window.getComputedStyle(document.getElementById('test1'));

Could have a better name of this variable, like "computedStyle".

> LayoutTests/fast/text/variations/optical-sizing.html:40
> +		found = true;
> +		testPassed("Found optical sizing");
> +		break;

Nit: Double indentation here is weird.
Comment 3 Myles C. Maxfield 2017-03-24 19:40:01 PDT
Created attachment 305354 [details]
Patch for committing
Comment 4 Myles C. Maxfield 2017-03-24 19:42:51 PDT
Created attachment 305355 [details]
Patch for committing
Comment 5 Build Bot 2017-03-24 20:48:09 PDT
Comment on attachment 305355 [details]
Patch for committing

Attachment 305355 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3407216

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html
Comment 6 Build Bot 2017-03-24 20:48:12 PDT
Created attachment 305359 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-03-24 20:52:19 PDT
Comment on attachment 305355 [details]
Patch for committing

Attachment 305355 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3407221

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html
Comment 8 Build Bot 2017-03-24 20:52:22 PDT
Created attachment 305360 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-03-24 20:58:45 PDT
Comment on attachment 305355 [details]
Patch for committing

Attachment 305355 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3407218

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html
Comment 10 Build Bot 2017-03-24 20:58:47 PDT
Created attachment 305361 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Myles C. Maxfield 2017-03-24 21:16:58 PDT
Created attachment 305362 [details]
Patch for committing
Comment 12 Build Bot 2017-03-24 22:50:02 PDT
Comment on attachment 305362 [details]
Patch for committing

Attachment 305362 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3407546

New failing tests:
fast/text/variations/optical-sizing.html
Comment 13 Build Bot 2017-03-24 22:50:05 PDT
Created attachment 305365 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 14 Myles C. Maxfield 2017-03-24 23:50:26 PDT
Committed r214394: <http://trac.webkit.org/changeset/214394>
Comment 15 Myles C. Maxfield 2017-03-25 00:42:53 PDT
Committed r214395: <http://trac.webkit.org/changeset/214395>