Bug 170083 – Add font-optical-sizing to CSSComputedStyleDeclaration

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Add font-optical-sizing to CSSComputedStyleDeclaration

[Myles C. Maxfield]

Created attachment 305334 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 305334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305334&action=review

r=me

> LayoutTests/fast/text/variations/optical-sizing.html:34
> +var x = window.getComputedStyle(document.getElementById('test1'));

Could have a better name of this variable, like "computedStyle".

> LayoutTests/fast/text/variations/optical-sizing.html:40
> +		found = true;
> +		testPassed("Found optical sizing");
> +		break;

Nit: Double indentation here is weird.

[Myles C. Maxfield]

Created attachment 305354 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 305355 [details]
Patch for committing

[Build Bot]

Comment on attachment 305355 [details]
Patch for committing

Attachment 305355 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3407216

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html

[Build Bot]

Created attachment 305359 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305355 [details]
Patch for committing

Attachment 305355 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3407221

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html

[Build Bot]

Created attachment 305360 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305355 [details]
Patch for committing

Attachment 305355 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3407218

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-font-family.html

[Build Bot]

Created attachment 305361 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 305362 [details]
Patch for committing

[Build Bot]

Comment on attachment 305362 [details]
Patch for committing

Attachment 305362 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3407546

New failing tests:
fast/text/variations/optical-sizing.html

[Build Bot]

Created attachment 305365 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Committed r214394: <http://trac.webkit.org/changeset/214394>

[Myles C. Maxfield]

Committed r214395: <http://trac.webkit.org/changeset/214395>