Bug 168895 – Implement font-optical-sizing

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Myles C. Maxfield]

https://drafts.csswg.org/css-fonts-4/#optical-sizing-control-the-font-optical-sizing-property

[Jon Lee]

rdar://problem/30429793

[Myles C. Maxfield]

Created attachment 304764 [details]
Patch

[Myles C. Maxfield]

Created attachment 304902 [details]
Patch

[Build Bot]

Comment on attachment 304902 [details]
Patch

Attachment 304902 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3364931

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 304904 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304902 [details]
Patch

Attachment 304902 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3364928

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 304905 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304902 [details]
Patch

Attachment 304902 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3365581

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 304908 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 304972 [details]
Patch

[Dean Jackson]

Comment on attachment 304972 [details]
Patch

Remember to edit Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js too! (Although this should really take its content from our new .json file)

[Myles C. Maxfield]

Committed r214364: <http://trac.webkit.org/changeset/214364>

[Ryan Haddad]

(In reply to Myles C. Maxfield from comment #12)
> Committed r214364: <http://trac.webkit.org/changeset/214364>

The LayoutTest for this change appears to be a flaky failure on Sierra:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Ftext%2Fvariations%2Foptical-sizing.html

[Myles C. Maxfield]

See also: https://bugs.webkit.org/show_bug.cgi?id=170083

[Myles C. Maxfield]

(In reply to Ryan Haddad from comment #13)
> (In reply to Myles C. Maxfield from comment #12)
> > Committed r214364: <http://trac.webkit.org/changeset/214364>
> 
> The LayoutTest for this change appears to be a flaky failure on Sierra:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Ftext%2Fvariations%2Foptical-sizing.html

I'm investigating the flakiness now.

[Myles C. Maxfield]

Committed r214467: <http://trac.webkit.org/changeset/214467>