Bug 168895 - Implement font-optical-sizing
Summary: Implement font-optical-sizing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 162815 170083
  Show dependency treegraph
 
Reported: 2017-02-26 21:43 PST by Myles C. Maxfield
Modified: 2017-03-28 00:31 PDT (History)
9 users (show)

See Also:


Attachments
Patch (27.62 KB, patch)
2017-03-17 00:32 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (27.83 KB, patch)
2017-03-19 15:07 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (3.11 MB, application/zip)
2017-03-19 16:04 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.43 MB, application/zip)
2017-03-19 16:04 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.55 MB, application/zip)
2017-03-19 18:03 PDT, Build Bot
no flags Details
Patch (27.81 KB, patch)
2017-03-20 17:16 PDT, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Jon Lee 2017-03-01 02:39:23 PST
rdar://problem/30429793
Comment 2 Myles C. Maxfield 2017-03-17 00:32:20 PDT
Created attachment 304764 [details]
Patch
Comment 3 Myles C. Maxfield 2017-03-19 15:07:10 PDT
Created attachment 304902 [details]
Patch
Comment 4 Build Bot 2017-03-19 16:04:10 PDT
Comment on attachment 304902 [details]
Patch

Attachment 304902 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3364931

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-03-19 16:04:21 PDT
Created attachment 304904 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-03-19 16:04:32 PDT
Comment on attachment 304902 [details]
Patch

Attachment 304902 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3364928

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2017-03-19 16:04:37 PDT
Created attachment 304905 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-03-19 18:03:43 PDT
Comment on attachment 304902 [details]
Patch

Attachment 304902 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3365581

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2017-03-19 18:03:45 PDT
Created attachment 304908 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Myles C. Maxfield 2017-03-20 17:16:19 PDT
Created attachment 304972 [details]
Patch
Comment 11 Dean Jackson 2017-03-24 11:57:20 PDT
Comment on attachment 304972 [details]
Patch

Remember to edit Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js too! (Although this should really take its content from our new .json file)
Comment 12 Myles C. Maxfield 2017-03-24 12:02:05 PDT
Committed r214364: <http://trac.webkit.org/changeset/214364>
Comment 13 Ryan Haddad 2017-03-24 17:11:13 PDT
(In reply to Myles C. Maxfield from comment #12)
> Committed r214364: <http://trac.webkit.org/changeset/214364>

The LayoutTest for this change appears to be a flaky failure on Sierra:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Ftext%2Fvariations%2Foptical-sizing.html
Comment 14 Myles C. Maxfield 2017-03-24 23:51:37 PDT
See also: https://bugs.webkit.org/show_bug.cgi?id=170083
Comment 15 Myles C. Maxfield 2017-03-25 00:24:43 PDT
(In reply to Ryan Haddad from comment #13)
> (In reply to Myles C. Maxfield from comment #12)
> > Committed r214364: <http://trac.webkit.org/changeset/214364>
> 
> The LayoutTest for this change appears to be a flaky failure on Sierra:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Ftext%2Fvariations%2Foptical-sizing.html

I'm investigating the flakiness now.
Comment 16 Myles C. Maxfield 2017-03-28 00:31:35 PDT
Committed r214467: <http://trac.webkit.org/changeset/214467>