Tighten RTCDatachannel creation and parameter getters
Created attachment 305330 [details] Patch
Comment on attachment 305330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305330&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:335 > + if (options.negotiated && !options.negotiated.value() && (label.length() > 65535 || options.protocol.length() > 65535)) USHRT_MAX? > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:341 > + if (options.id && options.id.value() > 65534) ">= USHRT_MAX"? If not, a named constant would be nice to make it obvious what this limit represents.
Comment on attachment 305330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305330&action=review > LayoutTests/webrtc/datachannel/basic.html:203 > + > + Nit: extra blank line.
Thanks for the review. The values are literally from the spec, I am not sure it is worth moving away from the spec
Created attachment 305481 [details] Patch for landing
Thanks for the review. (In reply to Eric Carlson from comment #3) > Comment on attachment 305330 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305330&action=review > > > LayoutTests/webrtc/datachannel/basic.html:203 > > + > > + > > Nit: extra blank line. Done
Comment on attachment 305481 [details] Patch for landing Clearing flags on attachment: 305481 Committed r214421: <http://trac.webkit.org/changeset/214421>
All reviewed patches have been landed. Closing bug.