Bug 170028 – webkitpy should be able to run API tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Srinivasan Vijayaraghavan]

webkitpy should be able to run API tests

[Srinivasan Vijayaraghavan]

Created attachment 305233 [details]
Patch

[Sam Weinig]

I don't understand why this is necessary? The api tests script is perl script, why involve another language?

[Alexey Proskuryakov]

It's to run API tests in EWS, which is all written in Python.

[Alexey Proskuryakov]

Comment on attachment 305233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305233&action=review

> Tools/Scripts/webkitpy/tool/steps/runtests.py:65
> +        if self._options.group == "api":

I'm not sure if this is quite right. As API tests run together with regular ones, marking the EWS queue as "api" doesn't seem to make sense.

[Srinivasan Vijayaraghavan]

(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 305233 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305233&action=review
> 
> > Tools/Scripts/webkitpy/tool/steps/runtests.py:65
> > +        if self._options.group == "api":
> 
> I'm not sure if this is quite right. As API tests run together with regular
> ones, marking the EWS queue as "api" doesn't seem to make sense.

This code runs when webkit-patch calls itself using a command such as "webkit-patch build-and-test --test --non-interactive --group=x". What's being checked here is the value of x that was passed, not any property of the queue itself.

The arguments above are generated in PatchAnalysisTask, which will be changed to allow group=api for running the API tests.

[Srinivasan Vijayaraghavan]

They won't always run together with the layout tests, for example if only one of them needs to be re-tested. So, we need a way to run them independently. The code in EarlyWarningSystem, EarlyWarningSystemTask etc would then decide whether to run both (default), or just one.

[WebKit Commit Bot]

Comment on attachment 305233 [details]
Patch

Clearing flags on attachment: 305233

Committed r214377: <http://trac.webkit.org/changeset/214377>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

*** Bug 106596 has been marked as a duplicate of this bug. ***