Bug 213421 - Delete dead code for old ews api tests
Summary: Delete dead code for old ews api tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 213296
  Show dependency tree / graph
 
Reported: 2020-06-19 17:33 PDT by Aakash Jain
Modified: 2020-06-19 18:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (13.93 KB, patch)
2020-06-19 17:35 PDT, Aakash Jain 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-06-19 17:33:08 PDT 
Delete dead code for old ews api tests. See Bug 213296 for details of old ews code deletion plan.

The code was dead code, as it was never completed and never used in production. There were few required parts of the logic missing like retrying without patch (in order to figure out whether the failure is introduced by the patch or is pre-existing).
Comment 1 Aakash Jain 2020-06-19 17:35:05 PDT 
Created attachment 402360 [details]
Patch
Comment 2 Aakash Jain 2020-06-19 17:46:15 PDT 
> Created attachment 402360 [details]
This effectively reverts r214363 and r214377.
Comment 3 Alexey Proskuryakov 2020-06-19 18:19:41 PDT 
Comment on attachment 402360 [details]
Patch

rs=me
Comment 4 Aakash Jain 2020-06-19 18:22:55 PDT 
Committed r263308: <https://trac.webkit.org/changeset/263308>
Comment 5 Radar WebKit Bug Importer 2020-06-19 18:23:15 PDT 
<rdar://problem/64551723>