Support RTCPeerConnectionState

[youenn fablet]

https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum

[youenn fablet]

Created attachment 305139 [details]
Patch

[youenn fablet]

Added test might not be interoperable.
Plan will be to move it to web-platform-tests when possible and fix any interop there.

[Jon Lee]

Comment on attachment 305139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305139&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-78
> -    // FIXME 169644: change to RTCSessionDescriptionInit

Why is this removed? The signature should be updated even if it's handled by the builtin.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-147
> -    // FIXME 169644: convert to (MediaStreamTrack or DOMString)

Why is this removed?

[Build Bot]

Comment on attachment 305139 [details]
Patch

Attachment 305139 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3390928

New failing tests:
media/video-main-content-autoplay.html

[Build Bot]

Created attachment 305150 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[youenn fablet]

(In reply to Jon Lee from comment #3)
> Comment on attachment 305139 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305139&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-78
> > -    // FIXME 169644: change to RTCSessionDescriptionInit
> 
> Why is this removed? The signature should be updated even if it's handled by
> the builtin.

I forgot to update it to RTCSessionDescriptionInit, will do at landing time.

> 
> > Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-147
> > -    // FIXME 169644: convert to (MediaStreamTrack or DOMString)
> 
> Why is this removed?

This is handled through overloading (see the two addTransceiver methods below).

[youenn fablet]

Created attachment 305151 [details]
Patch for landing

[Jon Lee]

Comment on attachment 305139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305139&action=review

>>> Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-147
>>> -    // FIXME 169644: convert to (MediaStreamTrack or DOMString)
>> 
>> Why is this removed?
> 
> This is handled through overloading (see the two addTransceiver methods below).

True, though it would be slightly nicer to match the spec exactly rather than having two overloaded methods.

[WebKit Commit Bot]

Comment on attachment 305151 [details]
Patch for landing

Rejecting attachment 305151 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 305151, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3391265

[youenn fablet]

Created attachment 305155 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 305155 [details]
Patch for landing

Clearing flags on attachment: 305155

Committed r214293: <http://trac.webkit.org/changeset/214293>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.