Bug 169897 - Loosen audio playback restrictions when the volume is 0
Summary: Loosen audio playback restrictions when the volume is 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-20 16:25 PDT by Matt Rajca
Modified: 2017-03-22 13:45 PDT (History)
1 user (show)

See Also:

Attachments
Patch (9.86 KB, patch)
2017-03-21 16:20 PDT, Matt Rajca 		eric.carlson: review+
mrajca: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2017-03-20 16:25:48 PDT 
If a media element is not muted but its volume is 0, we should not impose an audio playback restriction.
Comment 1 Matt Rajca 2017-03-20 16:26:15 PDT 
rdar://problem/31149965
Comment 2 Matt Rajca 2017-03-21 16:20:02 PDT 
Created attachment 305045 [details]
Patch
Comment 3 Matt Rajca 2017-03-21 18:45:17 PDT 
r214239
Comment 4 Ryan Haddad 2017-03-22 10:08:07 PDT 
This change appears to have caused API test WebKit2.WebsitePoliciesAutoplayEnabled to time out on iOS Simulator:
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/92
Comment 5 Matt Rajca 2017-03-22 10:11:09 PDT 
(In reply to Ryan Haddad from comment #4)
> This change appears to have caused API test
> WebKit2.WebsitePoliciesAutoplayEnabled to time out on iOS Simulator:
> https://build.webkit.org/builders/
> Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/92

Oh, interesting. Volume changes to media elements are not supported on iOS. I'll have the test only run on Mac.
Comment 6 Ryan Haddad 2017-03-22 13:35:22 PDT 
(In reply to Matt Rajca from comment #5)
> (In reply to Ryan Haddad from comment #4)
> > This change appears to have caused API test
> > WebKit2.WebsitePoliciesAutoplayEnabled to time out on iOS Simulator:
> > https://build.webkit.org/builders/
> > Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/92
> 
> Oh, interesting. Volume changes to media elements are not supported on iOS.
> I'll have the test only run on Mac.

Can this change be landed soon? It would be great to get the iOS bots back to green again.
Comment 7 Matt Rajca 2017-03-22 13:45:13 PDT 
(In reply to Ryan Haddad from comment #6)
> (In reply to Matt Rajca from comment #5)
> > (In reply to Ryan Haddad from comment #4)
> > > This change appears to have caused API test
> > > WebKit2.WebsitePoliciesAutoplayEnabled to time out on iOS Simulator:
> > > https://build.webkit.org/builders/
> > > Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/92
> > 
> > Oh, interesting. Volume changes to media elements are not supported on iOS.
> > I'll have the test only run on Mac.
> 
> Can this change be landed soon? It would be great to get the iOS bots back
> to green again.

Working on it now. https://bugs.webkit.org/show_bug.cgi?id=169969