Bug 169969 - Only run volume-related autoplay policy tests on Mac
Summary: Only run volume-related autoplay policy tests on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-22 13:44 PDT by Matt Rajca
Modified: 2017-03-23 09:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.80 KB, patch)
2017-03-22 13:55 PDT, Matt Rajca
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2017-03-22 13:44:54 PDT
iOS does not support volume changes to media elements so these tests are timing out.
Comment 1 Matt Rajca 2017-03-22 13:55:31 PDT
Created attachment 305125 [details]
Patch
Comment 2 Alex Christensen 2017-03-22 15:13:31 PDT
Comment on attachment 305125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305125&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:218
> +#if PLATFORM(MAC)

I would put a comment here explaining why this is disabled on iOS.
Comment 3 Matt Rajca 2017-03-22 15:22:31 PDT
(In reply to Alex Christensen from comment #2)
> Comment on attachment 305125 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305125&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:218
> > +#if PLATFORM(MAC)
> 
> I would put a comment here explaining why this is disabled on iOS.

Done.
Comment 4 Matt Rajca 2017-03-22 15:23:38 PDT
https://trac.webkit.org/changeset/214278/webkit
Comment 5 Radar WebKit Bug Importer 2017-03-23 09:36:32 PDT
<rdar://problem/31221127>