Bug 169866 - Add iceCandidatePoolSize to RTCConfiguration
Summary: Add iceCandidatePoolSize to RTCConfiguration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 169662
  Show dependency tree / graph
 
Reported: 2017-03-19 14:58 PDT by Jon Lee
Modified: 2017-03-22 18:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch (9.00 KB, patch)
2017-03-19 21:15 PDT, Jon Lee 		youennf: review+
Details | Formatted Diff | Diff
Patch for landing (10.10 KB, patch)
2017-03-20 14:57 PDT, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch for landing (10.10 KB, patch)
2017-03-20 19:35 PDT, Jon Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2017-03-19 14:58:19 PDT 
Add iceCandidatePoolSize to RTCConfiguration
Comment 1 Jon Lee 2017-03-19 21:15:36 PDT 
Created attachment 304912 [details]
Patch
Comment 2 youenn fablet 2017-03-20 08:36:12 PDT 
Comment on attachment 304912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304912&action=review

> LayoutTests/webrtc/rtcconfiguration-icecandidatepoolsize.html:12
> +shouldBe('config.iceCandidatePoolSize', '10');

Can we add some bad value cases, like 1000 or 'rr' for iceCandidatrPoolSize.
This test also seems like a good work test. Would be cool to make it use testharness.js
Comment 3 Jon Lee 2017-03-20 13:46:56 PDT 
I struggled to get the test harness to work at all. It might be something specific to my machine. In any case, I added test cases for undefined, null, -1, 1000, and 'string'.
Comment 4 Jon Lee 2017-03-20 14:57:59 PDT 
Created attachment 304952 [details]
Patch for landing
Comment 5 Jon Lee 2017-03-20 19:35:36 PDT 
Created attachment 304983 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-03-20 20:17:01 PDT 
Comment on attachment 304983 [details]
Patch for landing

Clearing flags on attachment: 304983

Committed r214209: <http://trac.webkit.org/changeset/214209>