Bug 169709 – Follow-up on comments for bug 169664

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jon Lee]

From Youenn:
> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:865
> +    Vector<RTCIceTransportState> transportStates;

I know this is untouched code.
Would you be able to use reserveInitialCapacity/uncheckedAppend

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:870
> +    m_peerConnection.updateIceConnectionState(static_cast<RTCIceConnectionState>(derivedState));

This looks bad, deriveAggregatedIceConnectionState should really be changed to return RTCIceConnectionState.

[Jon Lee]

(In reply to comment #0)
> From Youenn:
> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:865
> > +    Vector<RTCIceTransportState> transportStates;
> 
> I know this is untouched code.
> Would you be able to use reserveInitialCapacity/uncheckedAppend
> 
> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:870
> > +    m_peerConnection.updateIceConnectionState(static_cast<RTCIceConnectionState>(derivedState));
> 
> This looks bad, deriveAggregatedIceConnectionState should really be changed
> to return RTCIceConnectionState.

I have a patch for this, but should MediaEndpointPeerConnection be part of the xcodeproj at all?

[Jon Lee]

Created attachment 304913 [details]
Patch

[youenn fablet]

Comment on attachment 304913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304913&action=review

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:879
> +    Vector<RTCIceTransportState> transportStates(m_peerConnection.getTransceivers().size());

Please use reserveInitialCapacity to preallocate without creating the objects.

[Jon Lee]

Comment on attachment 304913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304913&action=review

>> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:879
>> +    Vector<RTCIceTransportState> transportStates(m_peerConnection.getTransceivers().size());
> 
> Please use reserveInitialCapacity to preallocate without creating the objects.

Done.

[Jon Lee]

Created attachment 304954 [details]
Patch for landing

[Jon Lee]

Created attachment 304981 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 304981 [details]
Patch for landing

Clearing flags on attachment: 304981

Committed r214207: <http://trac.webkit.org/changeset/214207>