Bug 169705 – [jsc] Add MacroAssemblerMIPS::storeFence()

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Guillaume Emont]

Part of my ongoing series uploading my patches that make MIPS work again.

[Guillaume Emont]

Created attachment 304565 [details]
Patch

The patch. We use sync with no parameters because I could not find a lighter option that would be a proper store fence. I think we could explore the idea of using SYNC_MB for both memoryFence() and storeFence() in the future though.

[Yusuke Suzuki]

Comment on attachment 304565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304565&action=review

r=me with comments.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2973
> +    {

Could you add a FIXME and comment about SYNC_MB thing?
And in FIXME, adding opened issue URL(in bugzilla) is desireable.

[Guillaume Emont]

Created attachment 305147 [details]
Patch

New version adding a FIXME with a link to https://bugs.webkit.org/show_bug.cgi?id=169984. The FIXME was added to MIPSAssembler::sync() as it is the common denominator for the issue, which likely affects both memoryFence() and storeFence() in the same way.

[Build Bot]

Comment on attachment 305147 [details]
Patch

Attachment 305147 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3391157

New failing tests:
media/video-main-content-autoplay.html

[Build Bot]

Created attachment 305153 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Guillaume Emont]

(In reply to Build Bot from comment #4)
> Comment on attachment 305147 [details]
> Patch
> 
> Attachment 305147 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/3391157
> 
> New failing tests:
> media/video-main-content-autoplay.html

I think we can safely assume this failure is unrelated with my patch?

[Yusuke Suzuki]

(In reply to Guillaume Emont from comment #6)
> (In reply to Build Bot from comment #4)
> > Comment on attachment 305147 [details]
> > Patch
> > 
> > Attachment 305147 [details] did not pass mac-debug-ews (mac):
> > Output: http://webkit-queues.webkit.org/results/3391157
> > 
> > New failing tests:
> > media/video-main-content-autoplay.html
> 
> I think we can safely assume this failure is unrelated with my patch?

I believe so.

[WebKit Commit Bot]

Comment on attachment 305147 [details]
Patch

Clearing flags on attachment: 305147

Committed r214300: <http://trac.webkit.org/changeset/214300>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.