Bug 169705 - [jsc] Add MacroAssemblerMIPS::storeFence()
Summary: [jsc] Add MacroAssemblerMIPS::storeFence()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-15 15:36 PDT by Guillaume Emont
Modified: 2017-03-23 02:25 PDT (History)
10 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2017-03-15 15:43 PDT, Guillaume Emont
no flags Details | Formatted Diff | Diff
Patch (2.13 KB, patch)
2017-03-22 17:58 PDT, Guillaume Emont
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-elcapitan (1.87 MB, application/zip)
2017-03-22 19:02 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Emont 2017-03-15 15:36:40 PDT
Part of my ongoing series uploading my patches that make MIPS work again.
Comment 1 Guillaume Emont 2017-03-15 15:43:19 PDT
Created attachment 304565 [details]
Patch

The patch. We use sync with no parameters because I could not find a lighter option that would be a proper store fence. I think we could explore the idea of using SYNC_MB for both memoryFence() and storeFence() in the future though.
Comment 2 Yusuke Suzuki 2017-03-21 17:20:55 PDT
Comment on attachment 304565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304565&action=review

r=me with comments.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2973
> +    {

Could you add a FIXME and comment about SYNC_MB thing?
And in FIXME, adding opened issue URL(in bugzilla) is desireable.
Comment 3 Guillaume Emont 2017-03-22 17:58:52 PDT
Created attachment 305147 [details]
Patch

New version adding a FIXME with a link to https://bugs.webkit.org/show_bug.cgi?id=169984. The FIXME was added to MIPSAssembler::sync() as it is the common denominator for the issue, which likely affects both memoryFence() and storeFence() in the same way.
Comment 4 Build Bot 2017-03-22 19:02:42 PDT
Comment on attachment 305147 [details]
Patch

Attachment 305147 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3391157

New failing tests:
media/video-main-content-autoplay.html
Comment 5 Build Bot 2017-03-22 19:02:45 PDT
Created attachment 305153 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Guillaume Emont 2017-03-22 23:34:50 PDT
(In reply to Build Bot from comment #4)
> Comment on attachment 305147 [details]
> Patch
> 
> Attachment 305147 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/3391157
> 
> New failing tests:
> media/video-main-content-autoplay.html

I think we can safely assume this failure is unrelated with my patch?
Comment 7 Yusuke Suzuki 2017-03-23 01:56:03 PDT
(In reply to Guillaume Emont from comment #6)
> (In reply to Build Bot from comment #4)
> > Comment on attachment 305147 [details]
> > Patch
> > 
> > Attachment 305147 [details] did not pass mac-debug-ews (mac):
> > Output: http://webkit-queues.webkit.org/results/3391157
> > 
> > New failing tests:
> > media/video-main-content-autoplay.html
> 
> I think we can safely assume this failure is unrelated with my patch?

I believe so.
Comment 8 WebKit Commit Bot 2017-03-23 02:25:09 PDT
Comment on attachment 305147 [details]
Patch

Clearing flags on attachment: 305147

Committed r214300: <http://trac.webkit.org/changeset/214300>
Comment 9 WebKit Commit Bot 2017-03-23 02:25:13 PDT
All reviewed patches have been landed.  Closing bug.