The EWS didn't catch the build failure because we use use GTK+ 3.16 in the Jhbuild. After submitting the patch for bug #169526 I made a build with the system's GTK+ and found this build failure: Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:571:49: error: cannot convert ‘GtkFileChooserNative* {aka _GtkFileChooserNative*}’ to ‘GtkNativeDialog* {aka _GtkNativeDialog*}’ for argument ‘1’ to ‘void gtk_native_dialog_set_modal(GtkNativeDialog*, gboolean)’ gtk_native_dialog_set_modal(dialog, TRUE); ^ The fix is straightforward and involves only adding a missing cast, I'm uploading a patch.
Created attachment 304205 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Committed r213776: <http://trac.webkit.org/changeset/213776>