Bug 169526 - [GTK] File choosers should run as modal by default if possible
Summary: [GTK] File choosers should run as modal by default if possible
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Adrian Perez
Depends on:
Reported: 2017-03-12 11:29 PDT by Adrian Perez
Modified: 2017-03-12 13:19 PDT (History)
7 users (show)

See Also:

Patch (2.29 KB, patch)
2017-03-12 12:35 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-03-12 11:29:30 PDT
Right now file chooser dialogs are never run as modal by default.
It would be desirable to try to obtain the GtkWindow where the
GtkWebView is embedded, set it as parent of the dialogs, and
enable running them as modal.
Comment 1 Adrian Perez 2017-03-12 12:35:50 PDT
Created attachment 304203 [details]
Comment 2 WebKit Commit Bot 2017-03-12 12:37:07 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2017-03-12 12:38:05 PDT
Comment on attachment 304203 [details]

Although possibly applications might not want this behavior, this definitely ought to be the default behavior to avoid unexpected bugs in applications.
Comment 4 WebKit Commit Bot 2017-03-12 13:19:07 PDT
Comment on attachment 304203 [details]

Clearing flags on attachment: 304203

Committed r213772: <http://trac.webkit.org/changeset/213772>
Comment 5 WebKit Commit Bot 2017-03-12 13:19:12 PDT
All reviewed patches have been landed.  Closing bug.