169518 – Variation fonts: Make sure that feature detection and preprocessor macros are right

RESOLVED FIXED Bug 169518

Variation fonts: Make sure that feature detection and preprocessor macros are right

https://bugs.webkit.org/show_bug.cgi?id=169518

Summary Variation fonts: Make sure that feature detection and preprocessor macros are...

Myles C. Maxfield

Reported 2017-03-11 20:55:00 PST

Do a pass over the previously-implemented things and make sure that feature detection is right.

Attachments
Test (7.45 KB, patch) 2017-03-25 12:35 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (10.86 KB, patch) 2017-03-25 14:04 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.17 MB, application/zip) 2017-03-25 15:09 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.12 MB, application/zip) 2017-03-25 15:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.84 MB, application/zip) 2017-03-25 15:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.02 MB, application/zip) 2017-03-25 21:44 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.13 MB, application/zip) 2017-03-26 00:30 PDT, Build Bot	no flags	Details
Patch (46.94 KB, patch) 2017-03-28 00:18 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.10 MB, application/zip) 2017-03-28 02:20 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (14.26 MB, application/zip) 2017-03-28 03:17 PDT, Build Bot	no flags	Details
Patch (40.75 KB, patch) 2017-03-28 15:19 PDT, Myles C. Maxfield	simon.fraser: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for committing (39.39 KB, patch) 2017-03-29 00:18 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (41.87 KB, patch) 2017-03-29 01:26 PDT, Myles C. Maxfield	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (939.19 KB, application/zip) 2017-03-29 02:31 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (867.31 KB, application/zip) 2017-03-29 02:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.69 MB, application/zip) 2017-03-29 02:49 PDT, Build Bot	no flags	Details
Show Obsolete (15) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2017-03-25 12:35:03 PDT

Created attachment 305393 [details] Test

Myles C. Maxfield

Comment 2 2017-03-25 14:04:21 PDT

Created attachment 305397 [details] Patch

Build Bot

Comment 3 2017-03-25 15:09:37 PDT

Comment on attachment 305397 [details] Patch Attachment 305397 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3410704 New failing tests: fast/text/font-weight-parse.html fast/text/font-stretch-parse.html fast/css/font-calculated-value.html css1/font_properties/font.html css2.1/t1508-c527-font-08-b.html fast/text/font-style-parse.html fast/text/font-selection-font-loading-api-parse.html fast/text/font-selection-font-face-parse.html

Build Bot

Comment 4 2017-03-25 15:09:40 PDT

Created attachment 305403 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-03-25 15:12:25 PDT

Comment on attachment 305397 [details] Patch Attachment 305397 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3410707 New failing tests: fast/text/font-weight-parse.html fast/text/font-stretch-parse.html fast/css/font-calculated-value.html css1/font_properties/font.html css2.1/t1508-c527-font-08-b.html fast/text/font-style-parse.html fast/text/font-selection-font-loading-api-parse.html fast/text/font-selection-font-face-parse.html

Build Bot

Comment 6 2017-03-25 15:12:28 PDT

Created attachment 305404 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-03-25 15:22:17 PDT

Comment on attachment 305397 [details] Patch Attachment 305397 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3410714 New failing tests: fast/text/font-weight-parse.html fast/text/font-stretch-parse.html fast/css/font-calculated-value.html css1/font_properties/font.html css2.1/t1508-c527-font-08-b.html fast/text/font-style-parse.html fast/text/font-selection-font-loading-api-parse.html fast/text/font-selection-font-face-parse.html

Build Bot

Comment 8 2017-03-25 15:22:20 PDT

Created attachment 305405 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-03-25 21:44:24 PDT

Comment on attachment 305397 [details] Patch Attachment 305397 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3411315 New failing tests: fast/scrolling/ios/touch-scroll-pointer-events-none.html fast/text/font-variations-feature-detection.html fast/history/page-cache-createObjectURL-using-open-panel.html

Build Bot

Comment 10 2017-03-25 21:44:27 PDT

Created attachment 305414 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-03-26 00:30:06 PDT

Build Bot

Comment 12 2017-03-26 00:30:08 PDT

Created attachment 305417 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 13 2017-03-28 00:18:29 PDT

Created attachment 305569 [details] Patch

Build Bot

Comment 14 2017-03-28 02:19:58 PDT

Comment on attachment 305569 [details] Patch Attachment 305569 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3425769 New failing tests: fast/text/font-weight-parse.html fast/text/font-style-parse.html fast/text/font-stretch-parse.html fast/text/font-selection-font-loading-api-parse.html fast/text/font-selection-font-face-parse.html

Build Bot

Comment 15 2017-03-28 02:20:00 PDT

Created attachment 305577 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 16 2017-03-28 03:17:48 PDT

Comment on attachment 305569 [details] Patch Attachment 305569 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3425967 New failing tests: fast/css/getComputedStyle/computed-style-font-family.html

Build Bot

Comment 17 2017-03-28 03:17:52 PDT

Created attachment 305582 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 18 2017-03-28 15:19:20 PDT

Created attachment 305649 [details] Patch

WebKit Commit Bot

Comment 19 2017-03-28 20:54:01 PDT

Comment on attachment 305649 [details] Patch Rejecting attachment 305649 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 305649, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: arse-expected.txt patching file LayoutTests/platform/mac-elcapitan/fast/text/font-stretch-parse-expected.txt patching file LayoutTests/platform/mac-elcapitan/fast/text/font-style-parse-expected.txt patching file LayoutTests/platform/mac-elcapitan/fast/text/font-weight-parse-expected.txt patching file LayoutTests/platform/mac/TestExpectations Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3431257

Myles C. Maxfield

Comment 20 2017-03-29 00:18:16 PDT

Created attachment 305712 [details] Patch for committing

Myles C. Maxfield

Comment 21 2017-03-29 01:26:07 PDT

Created attachment 305715 [details] Patch for committing

Build Bot

Comment 22 2017-03-29 02:31:20 PDT

Comment on attachment 305715 [details] Patch for committing Attachment 305715 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3432513 New failing tests: fast/text/font-style-parse.html fast/text/font-selection-font-loading-api-parse.html

Build Bot

Comment 23 2017-03-29 02:31:23 PDT

Created attachment 305718 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 24 2017-03-29 02:35:47 PDT

Comment on attachment 305715 [details] Patch for committing Attachment 305715 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3432520 New failing tests: fast/text/font-style-parse.html fast/text/font-selection-font-loading-api-parse.html

Build Bot

Comment 25 2017-03-29 02:35:50 PDT

Created attachment 305719 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 26 2017-03-29 02:49:06 PDT

Comment on attachment 305715 [details] Patch for committing Attachment 305715 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3432519 New failing tests: fast/text/font-style-parse.html fast/text/font-selection-font-loading-api-parse.html

Build Bot

Comment 27 2017-03-29 02:49:09 PDT

Created attachment 305721 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 28 2017-03-29 10:40:28 PDT

Committed r214546: <http://trac.webkit.org/changeset/214546>

Myles C. Maxfield

Comment 29 2017-03-29 12:23:31 PDT

Committed r214552: <http://trac.webkit.org/changeset/214552>

Myles C. Maxfield

Comment 30 2017-03-29 12:25:51 PDT

Committed r214555: <http://trac.webkit.org/changeset/214555>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Text

Assignee

Myles C. Maxfield

Reported

2017-03-11 20:55 PST

Modified

2017-03-29 12:25 PDT History

CC List

9 users Show

URL

Keywords

Depends on

Blocks

162815

Dependencies

tree graph