Bug 169518

Summary: Variation fonts: Make sure that feature detection and preprocessor macros are right
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dino, hyatt, jonlee, mmaxfield, rniwa, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162815    
Attachments:
Description Flags
Test
none
Patch
none
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews114 for mac-elcapitan
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch
none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch
simon.fraser: review+, commit-queue: commit-queue-
Patch for committing
none
Patch for committing
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-elcapitan
none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews115 for mac-elcapitan none

Description Myles C. Maxfield 2017-03-11 20:55:00 PST
Do a pass over the previously-implemented things and make sure that feature detection is right.
Comment 1 Myles C. Maxfield 2017-03-25 12:35:03 PDT
Created attachment 305393 [details]
Test
Comment 2 Myles C. Maxfield 2017-03-25 14:04:21 PDT
Created attachment 305397 [details]
Patch
Comment 3 Build Bot 2017-03-25 15:09:37 PDT
Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3410704

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-stretch-parse.html
fast/css/font-calculated-value.html
css1/font_properties/font.html
css2.1/t1508-c527-font-08-b.html
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
fast/text/font-selection-font-face-parse.html
Comment 4 Build Bot 2017-03-25 15:09:40 PDT
Created attachment 305403 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-03-25 15:12:25 PDT
Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3410707

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-stretch-parse.html
fast/css/font-calculated-value.html
css1/font_properties/font.html
css2.1/t1508-c527-font-08-b.html
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
fast/text/font-selection-font-face-parse.html
Comment 6 Build Bot 2017-03-25 15:12:28 PDT
Created attachment 305404 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-03-25 15:22:17 PDT
Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3410714

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-stretch-parse.html
fast/css/font-calculated-value.html
css1/font_properties/font.html
css2.1/t1508-c527-font-08-b.html
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
fast/text/font-selection-font-face-parse.html
Comment 8 Build Bot 2017-03-25 15:22:20 PDT
Created attachment 305405 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-03-25 21:44:24 PDT
Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3411315

New failing tests:
fast/scrolling/ios/touch-scroll-pointer-events-none.html
fast/text/font-variations-feature-detection.html
fast/history/page-cache-createObjectURL-using-open-panel.html
Comment 10 Build Bot 2017-03-25 21:44:27 PDT
Created attachment 305414 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-03-26 00:30:06 PDT
Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3411792

New failing tests:
fast/text/font-variations-feature-detection.html
Comment 12 Build Bot 2017-03-26 00:30:08 PDT
Created attachment 305417 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 13 Myles C. Maxfield 2017-03-28 00:18:29 PDT
Created attachment 305569 [details]
Patch
Comment 14 Build Bot 2017-03-28 02:19:58 PDT
Comment on attachment 305569 [details]
Patch

Attachment 305569 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3425769

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-style-parse.html
fast/text/font-stretch-parse.html
fast/text/font-selection-font-loading-api-parse.html
fast/text/font-selection-font-face-parse.html
Comment 15 Build Bot 2017-03-28 02:20:00 PDT
Created attachment 305577 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 16 Build Bot 2017-03-28 03:17:48 PDT
Comment on attachment 305569 [details]
Patch

Attachment 305569 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3425967

New failing tests:
fast/css/getComputedStyle/computed-style-font-family.html
Comment 17 Build Bot 2017-03-28 03:17:52 PDT
Created attachment 305582 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 18 Myles C. Maxfield 2017-03-28 15:19:20 PDT
Created attachment 305649 [details]
Patch
Comment 19 WebKit Commit Bot 2017-03-28 20:54:01 PDT
Comment on attachment 305649 [details]
Patch

Rejecting attachment 305649 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 305649, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
arse-expected.txt
patching file LayoutTests/platform/mac-elcapitan/fast/text/font-stretch-parse-expected.txt
patching file LayoutTests/platform/mac-elcapitan/fast/text/font-style-parse-expected.txt
patching file LayoutTests/platform/mac-elcapitan/fast/text/font-weight-parse-expected.txt
patching file LayoutTests/platform/mac/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3431257
Comment 20 Myles C. Maxfield 2017-03-29 00:18:16 PDT
Created attachment 305712 [details]
Patch for committing
Comment 21 Myles C. Maxfield 2017-03-29 01:26:07 PDT
Created attachment 305715 [details]
Patch for committing
Comment 22 Build Bot 2017-03-29 02:31:20 PDT
Comment on attachment 305715 [details]
Patch for committing

Attachment 305715 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3432513

New failing tests:
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
Comment 23 Build Bot 2017-03-29 02:31:23 PDT
Created attachment 305718 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 24 Build Bot 2017-03-29 02:35:47 PDT
Comment on attachment 305715 [details]
Patch for committing

Attachment 305715 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3432520

New failing tests:
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
Comment 25 Build Bot 2017-03-29 02:35:50 PDT
Created attachment 305719 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 26 Build Bot 2017-03-29 02:49:06 PDT
Comment on attachment 305715 [details]
Patch for committing

Attachment 305715 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3432519

New failing tests:
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
Comment 27 Build Bot 2017-03-29 02:49:09 PDT
Created attachment 305721 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 28 Myles C. Maxfield 2017-03-29 10:40:28 PDT
Committed r214546: <http://trac.webkit.org/changeset/214546>
Comment 29 Myles C. Maxfield 2017-03-29 12:23:31 PDT
Committed r214552: <http://trac.webkit.org/changeset/214552>
Comment 30 Myles C. Maxfield 2017-03-29 12:25:51 PDT
Committed r214555: <http://trac.webkit.org/changeset/214555>