WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169496
checkpatchrelevance: Exception message is printed twice due to ScriptError handler
https://bugs.webkit.org/show_bug.cgi?id=169496
Summary
checkpatchrelevance: Exception message is printed twice due to ScriptError ha...
Srinivasan Vijayaraghavan
Reported
2017-03-10 17:28:43 PST
Pcheckpatchrelevance: PException message is printed twice due to ScriptError handler
Attachments
Patch
(1.99 KB, patch)
2017-03-10 17:30 PST
,
Srinivasan Vijayaraghavan
no flags
Details
Formatted Diff
Diff
Patch
(3.30 KB, patch)
2017-03-10 20:53 PST
,
Srinivasan Vijayaraghavan
no flags
Details
Formatted Diff
Diff
Patch
(2.04 KB, patch)
2017-03-10 21:01 PST
,
Srinivasan Vijayaraghavan
no flags
Details
Formatted Diff
Diff
Patch
(2.03 KB, patch)
2017-03-10 21:03 PST
,
Srinivasan Vijayaraghavan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Srinivasan Vijayaraghavan
Comment 1
2017-03-10 17:30:54 PST
Created
attachment 304106
[details]
Patch
Srinivasan Vijayaraghavan
Comment 2
2017-03-10 17:38:17 PST
The effect of this change occurs at webkitpy/tool/commands/stepsequence.py: run_and_handle_errors() in the "except ScriptError" handler. (Link:
https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/stepsequence.py?order=name
)
Aakash Jain
Comment 3
2017-03-10 18:43:59 PST
looks fine to me.
WebKit Commit Bot
Comment 4
2017-03-10 20:30:50 PST
Comment on
attachment 304106
[details]
Patch Clearing flags on attachment: 304106 Committed
r213749
: <
http://trac.webkit.org/changeset/213749
>
WebKit Commit Bot
Comment 5
2017-03-10 20:30:53 PST
All reviewed patches have been landed. Closing bug.
Srinivasan Vijayaraghavan
Comment 6
2017-03-10 20:48:15 PST
Shouldn't have landed on a Friday evening 😞 this breaks one of the webkitpy tests.
Srinivasan Vijayaraghavan
Comment 7
2017-03-10 20:53:14 PST
Created
attachment 304125
[details]
Patch
Aakash Jain
Comment 8
2017-03-10 20:59:56 PST
This indicates that we need ews for webkitpy quickly.
Srinivasan Vijayaraghavan
Comment 9
2017-03-10 21:01:40 PST
Created
attachment 304126
[details]
Patch
Srinivasan Vijayaraghavan
Comment 10
2017-03-10 21:03:51 PST
Created
attachment 304129
[details]
Patch
Srinivasan Vijayaraghavan
Comment 11
2017-03-10 21:06:12 PST
Agreed re webkitpy ews. I've just requested cq on this one.
WebKit Commit Bot
Comment 12
2017-03-10 22:02:10 PST
Comment on
attachment 304129
[details]
Patch Clearing flags on attachment: 304129 Committed
r213751
: <
http://trac.webkit.org/changeset/213751
>
WebKit Commit Bot
Comment 13
2017-03-10 22:02:14 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug