Bug 169330 - JSC EWS repeat the log message thrice about patch not being relevant
Summary: JSC EWS repeat the log message thrice about patch not being relevant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-07 17:53 PST by Aakash Jain
Modified: 2017-03-09 13:13 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2017-03-09 12:09 PST, Srinivasan Vijayaraghavan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-03-07 17:53:59 PST
When JSC EWS finds that the patch is not relevant, it repeats the log message 3 times about patch not being relevant.

e.g.: 
https://webkit-queues.webkit.org/results/3262572
https://webkit-queues.webkit.org/results/3262491
https://webkit-queues.webkit.org/results/3262439

Checking relevance of patch
This patch does not have relevant changes.
This patch does not have relevant changes.
This patch does not have relevant changes.
Comment 1 Srinivasan Vijayaraghavan 2017-03-09 12:08:02 PST
Some of these are log messages, and the unit tests rely on testing emitted logs.

Will change one of the log levels to debug.
Comment 2 Srinivasan Vijayaraghavan 2017-03-09 12:09:33 PST
Created attachment 303945 [details]
Patch
Comment 3 Aakash Jain 2017-03-09 12:12:50 PST
Looks fine to me. Assuming it does solve the issue properly in your local testing.
Comment 4 Chris Dumez 2017-03-09 12:45:45 PST
Comment on attachment 303945 [details]
Patch

rs=me
Comment 5 WebKit Commit Bot 2017-03-09 13:13:44 PST
Comment on attachment 303945 [details]
Patch

Clearing flags on attachment: 303945

Committed r213658: <http://trac.webkit.org/changeset/213658>
Comment 6 WebKit Commit Bot 2017-03-09 13:13:49 PST
All reviewed patches have been landed.  Closing bug.