Bug 169386 – [WebCrypto] Implement SubtleCrypto::DeriveKey method

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Implement ECDH DeriveKey operation according to the spec: https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations.

[Jiewen Tan]

<rdar://problem/23789585>

[Jiewen Tan]

Created attachment 303892 [details]
Patch

[WebKit Commit Bot]

Attachment 303892 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:227:  CryptoAlgorithmAES_GCM::getKeyLength is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:189:  CryptoAlgorithmAES_CBC::getKeyLength is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:176:  CryptoAlgorithmAES_KW::getKeyLength is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:178:  CryptoAlgorithmAES_CFB::getKeyLength is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 4 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 303892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303892&action=review

Looks good. r=me.

> Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:-750
> -    ASSERT_NOT_REACHED();

Yay!

[Jiewen Tan]

(In reply to comment #4)
> Comment on attachment 303892 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303892&action=review
> 
> Looks good. r=me.
> 
> > Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:-750
> > -    ASSERT_NOT_REACHED();
> 
> Yay!

Thanks Brent for r+ my patch.

[WebKit Commit Bot]

Comment on attachment 303892 [details]
Patch

Clearing flags on attachment: 303892

Committed r213628: <http://trac.webkit.org/changeset/213628>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Alberto Lopez Perez]

Looks like this broke the 32-bit build of WebKitGTK+


https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/68007
https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/13248

[Jiewen Tan]

(In reply to comment #8)
> Looks like this broke the 32-bit build of WebKitGTK+
> 
> 
> https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/68007
> https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/13248

Oops. Sorry for it. Glad that you have fixed the problem.

[Carlos Alberto Lopez Perez]

(In reply to comment #9)
> (In reply to comment #8)
> > Looks like this broke the 32-bit build of WebKitGTK+
> > 
> > 
> > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/68007
> > https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/13248
> 
> Oops. Sorry for it. Glad that you have fixed the problem.

Have we? I still see the GTK+ 32-bit bots broken

https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release

[Brent Fulgham]

Prospective 32-bit GTK build fix landed in r213663: <http://trac.webkit.org/changeset/213663>