Bug 169354 – [Modern Media Controls] Fullscreen controls during Live Broadcast is completely broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

For Live Broadcast in fullscreen, we should disable the rewind and fast forward button and ensure we display the "Live Broadcast" status text instead of the scrubber.

[Antoine Quint]

<rdar://problem/30636370>

[Antoine Quint]

*** Bug 168810 has been marked as a duplicate of this bug. ***

[Antoine Quint]

Created attachment 304387 [details]
Patch

[Build Bot]

Comment on attachment 304387 [details]
Patch

Attachment 304387 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3321855

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html

[Build Bot]

Created attachment 304394 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304387 [details]
Patch

Attachment 304387 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3321856

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html

[Build Bot]

Created attachment 304395 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 304387 [details]
Patch

Attachment 304387 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3321852

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html

[Build Bot]

Created attachment 304396 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 304397 [details]
Patch

[Dean Jackson]

Comment on attachment 304397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304397&action=review

> Source/WebCore/Modules/modern-media-controls/media/seek-support.js:51
> +        this.control.enabled = this.mediaController.media.duration !== Number.POSITIVE_INFINITY;

It might be nice to have a isLiveStream() helper to make it clear what you're testing, in case you have to search for it later.

[WebKit Commit Bot]

Comment on attachment 304397 [details]
Patch

Clearing flags on attachment: 304397

Committed r213920: <http://trac.webkit.org/changeset/213920>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.