Bug 169233 - Enable SUPPORTS_TEXT_BASED_API in WebKit2 for iOS
Summary: Enable SUPPORTS_TEXT_BASED_API in WebKit2 for iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-06 16:02 PST by Aakash Jain
Modified: 2017-03-07 07:29 PST (History)
7 users (show)

See Also:

Attachments
Proposed patch (10.12 KB, patch)
2017-03-06 16:11 PST, Aakash Jain 		ap: review+
Details | Formatted Diff | Diff
Updated patch (10.08 KB, patch)
2017-03-06 19:53 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Updated patch (10.21 KB, patch)
2017-03-06 20:08 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-03-06 16:02:54 PST 
WebKit2 for iOS should enable SUPPORTS_TEXT_BASED_API.
Comment 1 Aakash Jain 2017-03-06 16:11:03 PST 
Created attachment 303579 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2017-03-06 16:30:48 PST 
Comment on attachment 303579 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303579&action=review

> Source/WebKit2/Configurations/Base.xcconfig:119
> +OTHER_TAPI_FLAGS = -x objective-c++ -std=c++11;

Do we want -fno-rtti here, to match WebKitLegacy?
Comment 3 Aakash Jain 2017-03-06 19:53:36 PST 
Created attachment 303605 [details]
Updated patch

> Do we want -fno-rtti here, to match WebKitLegacy?
Added -fno-rtti. Will land soon.
Comment 4 Aakash Jain 2017-03-06 20:08:41 PST 
Created attachment 303608 [details]
Updated patch

Added [sdk=iphone*] in xcconfig. Previous patch was enabling it for all platforms.

Please review again.
Comment 5 Alexey Proskuryakov 2017-03-06 22:29:05 PST 
Comment on attachment 303608 [details]
Updated patch

Good catch.
Comment 6 WebKit Commit Bot 2017-03-06 23:19:55 PST 
Comment on attachment 303608 [details]
Updated patch

Clearing flags on attachment: 303608

Committed r213504: <http://trac.webkit.org/changeset/213504>
Comment 7 WebKit Commit Bot 2017-03-06 23:19:59 PST 
All reviewed patches have been landed.  Closing bug.