Bug 168919 – Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

WebKit for iOS should enable SUPPORTS_TEXT_BASED_API.

[Aakash Jain]

Created attachment 302857 [details]
Proposed patch

[Tim Horton]

Comment on attachment 302857 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302857&action=review

> Source/WebKit/ChangeLog:3
> +        Enable SUPPORTS_TEXT_BASED_API in WebKit for iOS

WebKitLegacy, specifically, right?

[Build Bot]

Comment on attachment 302857 [details]
Proposed patch

Attachment 302857 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3203951

New failing tests:
scrollingcoordinator/ios/non-stable-viewport-scroll.html

[Build Bot]

Created attachment 302863 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Alexey Proskuryakov]

Comment on attachment 302857 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302857&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:3341
> +			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]  || [ \"${ACTION}\" = \"installapi\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n    ../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi";

Two spaces here.

> Source/WebKit/mac/migrate-headers.sh:35
> +if [ "${ACTION}" = "build" -o "${ACTION}" = "install" -o "${ACTION}" = "installhdrs"  -o "${ACTION}" = "installapi" ]; then

Two spaces here.

[Aakash Jain]

Created attachment 302868 [details]
Updated patch

Removed extra spaces.

[Aakash Jain]

Created attachment 302870 [details]
Updated patch

[WebKit Commit Bot]

Comment on attachment 302870 [details]
Updated patch

Clearing flags on attachment: 302870

Committed r213096: <http://trac.webkit.org/changeset/213096>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.