Bug 168919 - Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
Summary: Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-27 11:16 PST by Aakash Jain
Modified: 2017-03-07 07:29 PST (History)
6 users (show)

See Also:


Attachments
Proposed patch (4.63 KB, patch)
2017-02-27 11:22 PST, Aakash Jain
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (840.71 KB, application/zip)
2017-02-27 12:25 PST, Build Bot
no flags Details
Updated patch (3.10 KB, patch)
2017-02-27 13:48 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Updated patch (4.64 KB, patch)
2017-02-27 13:52 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-02-27 11:16:41 PST
WebKit for iOS should enable SUPPORTS_TEXT_BASED_API.
Comment 1 Aakash Jain 2017-02-27 11:22:04 PST
Created attachment 302857 [details]
Proposed patch
Comment 2 Tim Horton 2017-02-27 11:24:14 PST
Comment on attachment 302857 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302857&action=review

> Source/WebKit/ChangeLog:3
> +        Enable SUPPORTS_TEXT_BASED_API in WebKit for iOS

WebKitLegacy, specifically, right?
Comment 3 Build Bot 2017-02-27 12:25:54 PST
Comment on attachment 302857 [details]
Proposed patch

Attachment 302857 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3203951

New failing tests:
scrollingcoordinator/ios/non-stable-viewport-scroll.html
Comment 4 Build Bot 2017-02-27 12:25:57 PST
Created attachment 302863 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 Alexey Proskuryakov 2017-02-27 12:42:13 PST
Comment on attachment 302857 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302857&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:3341
> +			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]  || [ \"${ACTION}\" = \"installapi\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n    ../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi";

Two spaces here.

> Source/WebKit/mac/migrate-headers.sh:35
> +if [ "${ACTION}" = "build" -o "${ACTION}" = "install" -o "${ACTION}" = "installhdrs"  -o "${ACTION}" = "installapi" ]; then

Two spaces here.
Comment 6 Aakash Jain 2017-02-27 13:48:05 PST
Created attachment 302868 [details]
Updated patch

Removed extra spaces.
Comment 7 Aakash Jain 2017-02-27 13:52:43 PST
Created attachment 302870 [details]
Updated patch
Comment 8 WebKit Commit Bot 2017-02-27 14:56:18 PST
Comment on attachment 302870 [details]
Updated patch

Clearing flags on attachment: 302870

Committed r213096: <http://trac.webkit.org/changeset/213096>
Comment 9 WebKit Commit Bot 2017-02-27 14:56:24 PST
All reviewed patches have been landed.  Closing bug.