Bug 169204 - Web Inspector: REGRESSION(r213149): scope bar items in elements sidebar have wrong padding/margin
Summary: Web Inspector: REGRESSION(r213149): scope bar items in elements sidebar have ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-06 09:56 PST by Blaze Burg
Modified: 2017-03-10 16:45 PST (History)
10 users (show)

See Also:

Attachments
SCREENSHOT (48.88 KB, image/png)
2017-03-06 09:56 PST, Blaze Burg 		no flags Details
Patch (2.27 KB, patch)
2017-03-10 13:48 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (33.09 KB, image/png)
2017-03-10 14:10 PST, Devin Rousso 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Blaze Burg 2017-03-06 09:56:05 PST 
Created attachment 303521 [details]
SCREENSHOT

Not sure how this regressed so bad. Other scope bars are not affected.
Comment 1 Radar WebKit Bug Importer 2017-03-06 09:56:25 PST 
<rdar://problem/30871692>
Comment 2 Nikita Vasilyev 2017-03-06 11:07:05 PST 
The details sidebar (the right sidebar) in Resources and Debugger is also affected.

This happened once before over a year ago. I believe last time it was related to a flexbox change in WebKit.
Comment 3 Matt Baker 2017-03-08 16:37:03 PST 
Looks like this broke somewhere in:
http://trac.webkit.org/log/trunk/?mode=follow_copy&rev=213149&stop_rev=213115
Comment 4 Matt Baker 2017-03-08 16:38:56 PST 
Regressed in https://bugs.webkit.org/show_bug.cgi?id=168657.
Comment 5 Blaze Burg 2017-03-08 16:56:45 PST 
(In reply to comment #4)
> Regressed in https://bugs.webkit.org/show_bug.cgi?id=168657.

Not surprising. Can you take a look and see if our CSS is wrong?
Comment 6 Devin Rousso 2017-03-10 13:48:49 PST 
Created attachment 304068 [details]
Patch
Comment 7 Devin Rousso 2017-03-10 14:10:12 PST 
Created attachment 304074 [details]
[Image] After Patch is applied
Comment 8 Blaze Burg 2017-03-10 14:37:47 PST 
Comment on attachment 304068 [details]
Patch

r=me
Comment 9 Nikita Vasilyev 2017-03-10 14:52:46 PST 
Comment on attachment 304068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304068&action=review

> Source/WebInspectorUI/ChangeLog:16
> +        <select> from showing.

Nice!
Comment 10 WebKit Commit Bot 2017-03-10 16:45:42 PST 
Comment on attachment 304068 [details]
Patch

Clearing flags on attachment: 304068

Committed r213734: <http://trac.webkit.org/changeset/213734>
Comment 11 WebKit Commit Bot 2017-03-10 16:45:48 PST 
All reviewed patches have been landed.  Closing bug.